Skip to content

Improve error handling alignment with task guidelines #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jefim merged 4 commits into from
Jun 3, 2025
Merged

Improve error handling alignment with task guidelines #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
064cecc
Include the original error message in the output
ChargedByte May 26, 2025
e57f2aa
Wrap the thrown exception before rethrowing
ChargedByte May 26, 2025
0867a91
Bump template version to 1.2.0
ChargedByte Jun 3, 2025
03c82fd
Bump from .NET 6.0 to .NET 8.0
ChargedByte Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Frends.Template/Frends.Echo.Execute.Tests/Frends.Echo.Execute.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions Frends.Template/Frends.Echo.Execute/Frends.Echo.Execute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ public static Result Execute(
if (options.ThrowErrorOnFailure)
{
if (string.IsNullOrEmpty(options.ErrorMessageOnFailure))
throw;
throw new Exception(e.Message, e);

throw new Exception(options.ErrorMessageOnFailure, e);
}

var errorMessage = !string.IsNullOrEmpty(options.ErrorMessageOnFailure)
? options.ErrorMessageOnFailure
? $"{options.ErrorMessageOnFailure}: {e.Message}"
: e.Message;

return new Result
Expand Down
2 changes: 1 addition & 1 deletion Frends.Template/Frends.Echo.Execute/Frends.Echo.Execute.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Version>1.0.0</Version>
<Authors>Frends</Authors>
Expand Down
1 change: 1 addition & 0 deletions Frends.Template/workflows/Execute_build_and_test_on_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@ jobs:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_main.yml@main
with:
workdir: Frends.Echo.Execute
dotnet_version: 8.0.x
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}
1 change: 1 addition & 0 deletions Frends.Template/workflows/Execute_build_and_test_on_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_test.yml@main
with:
workdir: Frends.Echo.Execute
dotnet_version: 8.0.x
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}
test_feed_api_key: ${{ secrets.TASKS_TEST_FEED_API_KEY }}
1 change: 1 addition & 0 deletions Frends.Template/workflows/Execute_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ jobs:
uses: FrendsPlatform/FrendsTasks/.github/workflows/release.yml@main
with:
workdir: Frends.Echo.Execute
dotnet_version: 8.0.x
secrets:
feed_api_key: ${{ secrets.TASKS_FEED_API_KEY }}
2 changes: 1 addition & 1 deletion FrendsTaskTemplate.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<PackageType>Template</PackageType>
<PackageVersion>1.1.0</PackageVersion>
<PackageVersion>1.2.0</PackageVersion>
<PackageId>frendstasktemplate</PackageId>
<Title>Frends Task template</Title>
<Authors>Frends</Authors>
Expand Down
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ You can learn more about custom Tasks [here](https://docs.frends.com/en/articles
## Prerequisite

You will need the [.NET SDK](https://dotnet.microsoft.com/en-us/download/dotnet), at
minimum [.NET SDK 6.0](https://dotnet.microsoft.com/en-us/download/dotnet/6.0) is required. Since .NET 6.0 is EOL as of
2024-11-12, you should ideally use a newer version of the SDK, but Tasks should still target .NET 6.0 for the time
being.
minimum [.NET SDK 8.0](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) is required.

Frends Tasks are usually written in C#, for the best experience you will want a compatible integrated development
environment (IDE), some common examples are Visual Studio, Visual Studio Code and JetBrains Rider. You can also use any
Expand Down