Frends.azure data lake.list files#18
Open
MichalFrends1 wants to merge 4 commits intomainfrom
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jefim
requested changes
May 30, 2024
| public string ContainerName { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Name of the Azure Data Lake directory specifies the path where the data will be uploaded. |
| public string ClientSecret { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Name of the Azure Data Lake container where the data will be uploaded. |
| /// The type of the item (either "File" or "Directory"). | ||
| /// </summary> | ||
| /// <example>File</example> | ||
| public string Type { get; set; } |
Contributor
There was a problem hiding this comment.
Lets mimic the same Azure thing, so would be just bool IsDirectory
|
|
||
| try | ||
| { | ||
| if (options.ListingStructure == ListingStructure.Flat) |
Contributor
There was a problem hiding this comment.
Lets remove the options.ListingStructure altogether and simply replace it with a flag bool Recursive. This will simplify code and make it easier to understand for the user.
…ture for bool Recursive
Comment on lines
+105
to
+122
| foreach (var isRecursive in recursiveOptions) | ||
| { | ||
| var options = new Options | ||
| { | ||
| DictionaryName = "Temp", | ||
| Recursive = isRecursive, | ||
| }; | ||
|
|
||
| var result = await AzureDataLake.ListFiles(source, options, default); | ||
|
|
||
| Assert.IsTrue(result.FileList.Any(x => x.Name == "Temp/SubFolderFile")); | ||
| Assert.IsTrue(result.FileList.Any(x => x.Name == "Temp/SubFolderFile2")); | ||
| Assert.IsTrue(result.FileList.Any(x => x.URL.Contains("/Temp/SubFolderFile"))); | ||
| Assert.IsTrue(result.FileList.Any(x => x.URL.Contains("/Temp/SubFolderFile2"))); | ||
|
|
||
| Assert.IsFalse(result.FileList.Any(x => x.Name == "TestFile.txt")); | ||
| Assert.IsFalse(result.FileList.Any(x => x.Name == "TestFile2.txt")); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select
Comment on lines
+203
to
+220
| foreach (var isRecursive in recursiveOptions) | ||
| { | ||
| var options = new Options | ||
| { | ||
| DictionaryName = "Temp", | ||
| Recursive = isRecursive, | ||
| }; | ||
|
|
||
| var result = await AzureDataLake.ListFiles(source, options, default); | ||
|
|
||
| Assert.IsTrue(result.FileList.Any(x => x.Name == "Temp/SubFolderFile")); | ||
| Assert.IsTrue(result.FileList.Any(x => x.Name == "Temp/SubFolderFile2")); | ||
| Assert.IsTrue(result.FileList.Any(x => x.URL.Contains("/Temp/SubFolderFile"))); | ||
| Assert.IsTrue(result.FileList.Any(x => x.URL.Contains("/Temp/SubFolderFile2"))); | ||
|
|
||
| Assert.IsFalse(result.FileList.Any(x => x.Name == "TestFile.txt")); | ||
| Assert.IsFalse(result.FileList.Any(x => x.Name == "TestFile2.txt")); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select
Comment on lines
+54
to
+57
| catch (Exception ex) | ||
| { | ||
| throw new ArgumentException("ListFileHandler error: ", ex); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
|
CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.AzureDataLake/actions/runs/9319381442?pr=18 |
|
CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.AzureDataLake/actions/runs/9345458004?pr=18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 10