Add zero imputation and use lmer#34
Open
lmartinezgili wants to merge 2 commits intoFrederickHuangLin:masterfrom
Open
Add zero imputation and use lmer#34lmartinezgili wants to merge 2 commits intoFrederickHuangLin:masterfrom
lmartinezgili wants to merge 2 commits intoFrederickHuangLin:masterfrom
Conversation
Owner
|
Thanks for your valuable inputs! How to handle zeros is critical and also controversial in microbiome studies, so I turn to keep that part as it is to make it consistent with the ANCOM paper. As for switching nlme:lme to lmerTest:lmer, will definitely reflect it in the ANCOM R package (upcoming soon)! Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for ANCOM!
I have added a couple of changes which might be of interest:
I also suggest changing the function name to lower case