fix: prevent duplicated widget rendering on the home screen (issue #320)#360
Open
svenburkard wants to merge 2 commits intoFossifyOrg:mainfrom
Open
Conversation
Author
|
Hi @naveensingh, I made the bug of #320 reproducible and fixed it with this PR as you can see from the before/after videos. My plan was to remove the related debug code of the TODO comments after the review is done. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Tests performed
adb shell am start -n org.fossify.home.debug/org.fossify.home.activities.MainActivity -a org.fossify.home.action.DEBUG_FORCE_WIDGET_FIRST_DRAWBefore & after preview
Before:
https://github.com/user-attachments/assets/3347e6df-3ca8-4985-9953-0cab65e4d97d
After:
https://github.com/user-attachments/assets/83c91be2-b001-4663-994d-0fff417dbe12
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).