feat: add support for dual apps with Android profiles#357
Open
svenburkard wants to merge 9 commits intoFossifyOrg:mainfrom
Open
feat: add support for dual apps with Android profiles#357svenburkard wants to merge 9 commits intoFossifyOrg:mainfrom
svenburkard wants to merge 9 commits intoFossifyOrg:mainfrom
Conversation
Author
|
I'll take a look at it the weekend to make the detekt check happy. |
Author
|
Hi @naveensingh, I've fixed the open detekt violations via 6938e1b, c4de678 and a5c756a. I also rebuilt the APK from last commit (a5c756a) and repeated the tests with Android 16 another time successfully. Regarding commit c4de678: I’m not fully happy with the naming there. I mainly chose this approach to resolve the detekt magic-number violation. If you would have handled that differently or prefer an alternative solution like suppress, please let me know. I’d be happy to get your review when you have time. Thanks a lot, |
This was referenced Feb 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Tests performed
Before & after preview
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).