Skip to content

fix: remove fragments from PagerAdapters when item is destroyed. #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Feb 12, 2026
Merged

fix: remove fragments from PagerAdapters when item is destroyed. #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion app/src/main/kotlin/org/fossify/calendar/adapters/MyDayPagerAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package org.fossify.calendar.adapters

import android.os.Bundle
import android.util.SparseArray
import android.view.ViewGroup
import androidx.fragment.app.Fragment
import androidx.fragment.app.FragmentManager
import androidx.fragment.app.FragmentStatePagerAdapter
Expand All @@ -24,10 +25,22 @@ class MyDayPagerAdapter(fm: FragmentManager, private val mCodes: List<String>, p
fragment.arguments = bundle
fragment.mListener = mListener

mFragments.put(position, fragment)
return fragment
}

override fun instantiateItem(container: ViewGroup, position: Int): Any {
val item = super.instantiateItem(container, position)
if (item is DayFragment) {
mFragments.put(position, item)
}
return item
}

override fun destroyItem(container: ViewGroup, position: Int, `object`: Any) {
mFragments.remove(position)
super.destroyItem(container, position, `object`)
}

fun updateCalendars(pos: Int) {
for (i in -1..1) {
mFragments[pos + i]?.updateCalendar()
Expand Down
15 changes: 14 additions & 1 deletion app/src/main/kotlin/org/fossify/calendar/adapters/MyMonthDayPagerAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package org.fossify.calendar.adapters

import android.os.Bundle
import android.util.SparseArray
import android.view.ViewGroup
import androidx.fragment.app.Fragment
import androidx.fragment.app.FragmentManager
import androidx.fragment.app.FragmentStatePagerAdapter
Expand All @@ -23,10 +24,22 @@ class MyMonthDayPagerAdapter(fm: FragmentManager, private val mCodes: List<Strin
fragment.arguments = bundle
fragment.listener = mListener

mFragments.put(position, fragment)
return fragment
}

override fun instantiateItem(container: ViewGroup, position: Int): Any {
val item = super.instantiateItem(container, position)
if (item is MonthDayFragment) {
mFragments.put(position, item)
}
return item
}

override fun destroyItem(container: ViewGroup, position: Int, `object`: Any) {
mFragments.remove(position)
super.destroyItem(container, position, `object`)
}

fun updateCalendars(pos: Int) {
for (i in -1..1) {
mFragments[pos + i]?.updateCalendar()
Expand Down
15 changes: 14 additions & 1 deletion app/src/main/kotlin/org/fossify/calendar/adapters/MyMonthPagerAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package org.fossify.calendar.adapters

import android.os.Bundle
import android.util.SparseArray
import android.view.ViewGroup
import androidx.fragment.app.Fragment
import androidx.fragment.app.FragmentManager
import androidx.fragment.app.FragmentStatePagerAdapter
Expand All @@ -23,10 +24,22 @@ class MyMonthPagerAdapter(fm: FragmentManager, private val mCodes: List<String>,
fragment.arguments = bundle
fragment.listener = mListener

mFragments.put(position, fragment)
return fragment
}

override fun instantiateItem(container: ViewGroup, position: Int): Any {
val item = super.instantiateItem(container, position)
if (item is MonthFragment) {
mFragments.put(position, item)
}
return item
}

override fun destroyItem(container: ViewGroup, position: Int, `object`: Any) {
mFragments.remove(position)
super.destroyItem(container, position, `object`)
}

fun updateCalendars(pos: Int) {
for (i in -1..1) {
mFragments[pos + i]?.updateCalendar()
Expand Down
15 changes: 14 additions & 1 deletion app/src/main/kotlin/org/fossify/calendar/adapters/MyWeekPagerAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package org.fossify.calendar.adapters

import android.os.Bundle
import android.util.SparseArray
import android.view.ViewGroup
import androidx.fragment.app.Fragment
import androidx.fragment.app.FragmentManager
import androidx.fragment.app.FragmentStatePagerAdapter
Expand All @@ -24,10 +25,22 @@ class MyWeekPagerAdapter(fm: FragmentManager, private val mWeekTimestamps: List<
fragment.arguments = bundle
fragment.listener = mListener

mFragments.put(position, fragment)
return fragment
}

override fun instantiateItem(container: ViewGroup, position: Int): Any {
val item = super.instantiateItem(container, position)
if (item is WeekFragment) {
mFragments.put(position, item)
}
return item
}

override fun destroyItem(container: ViewGroup, position: Int, `object`: Any) {
mFragments.remove(position)
super.destroyItem(container, position, `object`)
}

fun updateScrollY(pos: Int, y: Int) {
mFragments[pos - 1]?.updateScrollY(y)
mFragments[pos + 1]?.updateScrollY(y)
Expand Down
15 changes: 14 additions & 1 deletion app/src/main/kotlin/org/fossify/calendar/adapters/MyYearPagerAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package org.fossify.calendar.adapters

import android.os.Bundle
import android.util.SparseArray
import android.view.ViewGroup
import androidx.fragment.app.Fragment
import androidx.fragment.app.FragmentManager
import androidx.fragment.app.FragmentStatePagerAdapter
Expand All @@ -23,10 +24,22 @@ class MyYearPagerAdapter(fm: FragmentManager, val mYears: List<Int>, private val
fragment.arguments = bundle
fragment.listener = mListener

mFragments.put(position, fragment)
return fragment
}

override fun instantiateItem(container: ViewGroup, position: Int): Any {
val item = super.instantiateItem(container, position)
if (item is YearFragment) {
mFragments.put(position, item)
}
return item
}

override fun destroyItem(container: ViewGroup, position: Int, `object`: Any) {
mFragments.remove(position)
super.destroyItem(container, position, `object`)
}

fun updateCalendars(pos: Int) {
for (i in -1..1) {
mFragments[pos + i]?.updateCalendar()
Expand Down
Loading