chore: use-either-for-composable-branching

[ryanbas21]

JIRA Ticket

n/s

Description

look at what some either refactors could look like

[changeset-bot]

⚠️ No Changeset found

Latest commit: 657043d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cbff3282-c9ff-4cd3-85b3-7c0e57d56529

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch either-refactor

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 657043d

Command	Status	Duration	Result
nx run-many -t build --no-agents	✅ Succeeded	4s	View ↗
nx affected -t build lint test typecheck e2e-ci	✅ Succeeded	1m 53s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-05-05 20:47:21 UTC

[nx-cloud]

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

View detailed reasoning in Nx Cloud ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

[pkg-pr-new]

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@621

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@621

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@621

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@621

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@621

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@621

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@621

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@621

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@621

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@621

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@621

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@621

commit: 657043d

[codecov-commenter]

Codecov Report

❌ Patch coverage is 92.07048% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.49%. Comparing base (5d6747a) to head (657043d).
⚠️ Report is 90 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/davinci-client/src/lib/davinci.utils.ts	91.19%	14 Missing ⚠️
...ges/davinci-client/src/lib/client.store.effects.ts	94.11%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #621       +/-   ##
===========================================
- Coverage   70.90%   58.49%   -12.41%     
===========================================
  Files          53       22       -31     
  Lines        2021     2465      +444     
  Branches      377      372        -5     
===========================================
+ Hits         1433     1442        +9     
- Misses        588     1023      +435     

Files with missing lines	Coverage Δ
...ges/davinci-client/src/lib/client.store.effects.ts	71.28% <94.11%> (ø)
packages/davinci-client/src/lib/davinci.utils.ts	93.04% <91.19%> (ø)

... and 73 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Deployed 0d516d6 to https://ForgeRock.github.io/ping-javascript-sdk/pr-621/0d516d684713b3a2ba51ad968423a1f8ad209959 branch gh-pages in ForgeRock/ping-javascript-sdk

[github-actions]

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/device-client - 0.0 KB (-10.0 KB, -100.0%)
🔻 @forgerock/journey-client - 0.0 KB (-91.9 KB, -100.0%)

📊 Minor Changes

📉 @forgerock/davinci-client - 48.5 KB (-0.1 KB)

➖ No Changes

➖ @forgerock/device-client - 10.0 KB
➖ @forgerock/oidc-client - 25.2 KB
➖ @forgerock/sdk-utilities - 11.2 KB
➖ @forgerock/sdk-types - 7.9 KB
➖ @forgerock/protect - 144.6 KB
➖ @forgerock/journey-client - 91.9 KB
➖ @forgerock/storage - 1.5 KB
➖ @forgerock/sdk-oidc - 4.8 KB
➖ @forgerock/sdk-request-middleware - 4.5 KB
➖ @forgerock/sdk-logger - 1.6 KB
➖ @forgerock/iframe-manager - 2.4 KB

---

14 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated

• Current Size: Total gzipped size of all files in the package's dist directory
• Baseline: Comparison against the latest build from the main branch
• Files included: All build outputs except source maps and TypeScript build cache
• Exclusions: .map, .tsbuildinfo, and .d.ts.map files

---

_{🔄 Updated automatically on each push to this PR}