Skip to content

Conversation

@vibhorgoswami
Copy link
Contributor

@vibhorgoswami vibhorgoswami commented Jan 14, 2026

JIRA Ticket

SDKS-4598

Description

Create a single test app for Android similar to iOS app. This includes MFA, DaVinci and Journey.

Screenshots

image image image image image image

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.66%. Comparing base (c862e33) to head (e87c9f7).

Additional details and impacted files
@@              Coverage Diff               @@
##             develop     #151       +/-   ##
==============================================
+ Coverage      27.26%   47.66%   +20.40%     
- Complexity       833     1198      +365     
==============================================
  Files            287      293        +6     
  Lines           8305     8553      +248     
  Branches        1132     1166       +34     
==============================================
+ Hits            2264     4077     +1813     
+ Misses          5799     3958     -1841     
- Partials         242      518      +276     
Flag Coverage Δ
integration-tests 28.56% <ø> (?)
unit-tests 27.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vibhorgoswami vibhorgoswami marked this pull request as ready for review January 14, 2026 19:18
…entication schemes and implement notification permission handling
…ing, and update text styles for better readability
…ltiple screens and apply padding adjustments for better layout consistency
Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app looks great! 👍🏻
A few things to fix...

//Protect
implementation(project(":protect"))

// MFA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MFA -> Device Binding

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand which libraries are required here?

@spetrov
Copy link
Contributor

spetrov commented Jan 15, 2026

This should probably say "Device Check" (not sure how actually - "secured" means that the device is not rooted, right?)
image

Or maybe just call it "Device ID", since we show the id below it... Also, maybe add device id in the "Device Info" screen too...

…tup, add initial destination handling from intents, and introduce notification response screen navigation
…g and update settings and about navigation routes
@vibhorgoswami
Copy link
Contributor Author

I updated the Device Info to say Device ID. However, we're checking if the tampering score is greater than 0.0 we will change it to device unsecured and color will be red.

…enforce dependency versions, and update device info title
…ceInfo and DeviceManagement screens with TopAppBar integration
@vibhorgoswami vibhorgoswami requested a review from spetrov January 16, 2026 16:55
…or user profiles and tokens, allowing selection between Journey, DaVinci, and OIDC types with corresponding actions.
…eryEndpoint with dummy values for testing purposes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants