Skip to content

SDSK-4549: Update Protect Callback With New Signals SDK Config#581

Open
SteinGabriel wants to merge 4 commits intodevelopfrom
SDKS-4549
Open

SDSK-4549: Update Protect Callback With New Signals SDK Config#581
SteinGabriel wants to merge 4 commits intodevelopfrom
SDKS-4549

Conversation

@SteinGabriel
Copy link

JIRA Ticket

Description

This PR updates Ping Protect initialization to support the new signalsInitializationOptions callback property from AM.

What Changed

  • PingOneProtectInitializeCallback#getConfig() now:
  • returns signalsInitializationOptions directly when present as an object
  • falls back to legacy config construction when missing/invalid
  • ping-protect types widened to support pass-through init option shapes
    (SignalsInitializationOptions, ProtectNodeInitializeConfig)
  • PIProtect.start() now resumes behavioral collection when
    behavioralDataCollection is true or 'true'
  • Added/updated unit tests for:
  • valid signalsInitializationOptions pass-through
  • invalid/missing fallback behavior
  • 'true'/'false' behavioral collection handling in ping-protect

How Has This Been Tested?

Tested with the e2e autoscript apps as well as added a test assertion for our automated e2e test suite.

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

🦋 Changeset detected

Latest commit: 7890f37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@forgerock/javascript-sdk Minor
@forgerock/ping-protect Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Mar 3, 2026

View your CI Pipeline Execution ↗ for commit 7890f37

Command Status Duration Result
nx affected -t build lint test docs e2e-ci ✅ Succeeded 38s View ↗
nx-cloud record -- nx format:check --verbose ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-03 20:29:09 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 3, 2026

Open in StackBlitz

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/javascript-sdk@581
pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/ping-protect@581
pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/token-vault@581

commit: 7890f37

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.50%. Comparing base (04ae8bb) to head (7890f37).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #581      +/-   ##
===========================================
+ Coverage    57.14%   58.50%   +1.36%     
===========================================
  Files          105      105              
  Lines        31752    28400    -3352     
  Branches      1800     1792       -8     
===========================================
- Hits         18145    16616    -1529     
+ Misses       13607    11784    -1823     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants