SDSK-4549: Update Protect Callback With New Signals SDK Config#581
Open
SteinGabriel wants to merge 4 commits intodevelopfrom
Open
SDSK-4549: Update Protect Callback With New Signals SDK Config#581SteinGabriel wants to merge 4 commits intodevelopfrom
SteinGabriel wants to merge 4 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 7890f37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 7890f37
☁️ Nx Cloud last updated this comment at |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #581 +/- ##
===========================================
+ Coverage 57.14% 58.50% +1.36%
===========================================
Files 105 105
Lines 31752 28400 -3352
Branches 1800 1792 -8
===========================================
- Hits 18145 16616 -1529
+ Misses 13607 11784 -1823 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Description
This PR updates Ping Protect initialization to support the new
signalsInitializationOptionscallback property from AM.What Changed
PingOneProtectInitializeCallback#getConfig()now:signalsInitializationOptionsdirectly when present as an objectping-protecttypes widened to support pass-through init option shapes(
SignalsInitializationOptions,ProtectNodeInitializeConfig)PIProtect.start()now resumes behavioral collection whenbehavioralDataCollectionistrueor'true'signalsInitializationOptionspass-through'true'/'false'behavioral collection handling inping-protectHow Has This Been Tested?
Tested with the e2e autoscript apps as well as added a test assertion for our automated e2e test suite.