Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-fork.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ jobs:
- run: git branch --track main origin/main || true

- run: pnpm nx format:check
- run: pnpm nx affected -t build typecheck lint test e2e-ci
- run: pnpm nx affected -t build typecheck lint test e2e
1 change: 1 addition & 0 deletions .github/workflows/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ env:
jobs:
label-pr:
runs-on: ubuntu-latest
if: ${{github.event.pull_request.head.repo.full_name == github.repository}}
steps:
- uses: actions/checkout@v3
with:
Expand Down
6 changes: 6 additions & 0 deletions packages/ping-protect/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 4.6.3

### Patch Changes

- [#575](https://github.com/ForgeRock/forgerock-javascript-sdk/pull/575) [`8ccfef4`](https://github.com/ForgeRock/forgerock-javascript-sdk/commit/8ccfef4532f219960f66e0d283cd6f8585a849f8) Thanks [@ryanbas21](https://github.com/ryanbas21)! - fixes the type of the options param in `PIProtect.start` so it better aligns with output from `PingOneProtectInitializeCallback.getConfig()` as defined in `javascript-sdk` (importantly it no longer expects `_type` and `_action` fields)

## 4.6.2

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/ping-protect/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@forgerock/ping-protect",
"version": "4.6.2",
"version": "4.6.3",
"private": false,
"type": "module",
"files": ["./dist/*"],
Expand Down
4 changes: 2 additions & 2 deletions packages/ping-protect/src/lib/ping-protect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type InitParams = Omit<ProtectInitializeConfig, '_type' | '_action'>;
declare global {
interface Window {
_pingOneSignals: {
init: (initParams?: ProtectInitializeConfig) => Promise<void>;
init: (initParams?: InitParams) => Promise<void>;
getData: () => Promise<string>;
pauseBehavioralData: () => void;
resumeBehavioralData: () => void;
Expand Down Expand Up @@ -56,7 +56,7 @@ export abstract class PIProtect {
* @param {InitParams} options - The init parameters
* @returns {Promise<void>} - Returns a promise
*/
public static async start(options: ProtectInitializeConfig): Promise<void> {
public static async start(options: InitParams): Promise<void> {
try {
/*
* Load the Ping Signals SDK
Expand Down
Loading