chore(_example): run multiple docker executors configured from _example/.env#1617
Open
Scra3 wants to merge 1 commit into
Open
chore(_example): run multiple docker executors configured from _example/.env#1617Scra3 wants to merge 1 commit into
Scra3 wants to merge 1 commit into
Conversation
…le/.env Add start:with-executor:multiple-instance[:build] (agent + the 2 docker executors behind the nginx gateway). All config comes from packages/_example/.env — nothing to edit in the executor example: a small wrapper script sources it, translates host-local URLs (localhost/127.0.0.1/dev domains) so containers reach the host, waits for the agent, then delegates. The executor example's `executors`/`executors:build` scripts stay config-agnostic (pure `docker compose up`), so running them standalone uses that package's own env, not _example/.env. Also fix the build context (../.. -> ../../.. so the Dockerfile's COPY . . sees the repo root) and map the *.development.forestadmin.com dev domains to the host so the containers can reach a local orchestrator. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Adds a one-command way to run the agent + the 2 docker executors (behind the nginx gateway on :3400), with all config coming from
packages/_example/.env— nothing to edit in the executor example.New scripts (in
packages/_example):start:with-executor:multiple-instance— agent + docker executors (reuses the pre-built image)start:with-executor:multiple-instance:build— same, rebuilding the executor imageHow
packages/_example/scripts/start-docker-executors.shsources_example/.env, translates host-local URLs (localhost/127.0.0.1/*.development.forestadmin.com) so the containers can reach the host, waits for the agent, then delegates.executors/executors:buildscripts stay config-agnostic (puredocker compose up). Run standalone from the executor example dir, they use that package's own env — not_example/.env.Fixes to the existing compose
build.context../..→../../..so the Dockerfile'sCOPY . .sees the repo root (was failing withlstat .../packages/packages).*.development.forestadmin.comdev domains to the host viaextra_hosts(they resolve to 127.0.0.1 on the host; inert for prodapi.forestadmin.com), so containers can reach a local orchestrator..env.executorsflow from the docs/header (config now lives only in_example/.env).🤖 Generated with Claude Code
Note
Run multiple docker executors configured from
_example/.envstart-docker-executors.shscript that sourcespackages/_example/.env, rewriteslocalhost/127.0.0.1endpoints tohost.docker.internal, and waits for the agent to be reachable before starting executors.start:with-executor:multiple-instanceandstart:with-executor:multiple-instance:buildscripts topackages/_example/package.jsonthat run the agent and docker executors concurrently viaconcurrently --kill-others.docker-compose.executors.ymlto addextra_hostsentries mapping Forest local-dev domains tohost-gateway, and changes theexecutor-1build context from../..to../../..(repo root).executor-1may include unintended files from the repo root in the image.Macroscope summarized 47612a6.