Conversation
ForNeVeR
changed the title
There was a problem hiding this comment.
Pull request overview
This PR standardizes .NET SDK configuration across all GitHub Actions workflows by utilizing the dotNetJob helper function instead of manually configuring jobs. The PR title contains a typo ("correvt" should be "correct"), but the actual changes are sound.
Changes:
- Refactored the "nuget" and "publish-docs" jobs in the F# workflow generator to use
dotNetJobhelper instead of manual job configuration - Removed hardcoded .NET SDK version "8.x" from the docs workflow, now relying on global.json (version 10.0.102)
- Added consistent environment variables, NuGet package caching, and SDK setup across all .NET jobs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/github-actions.fsx | Changed "nuget" and "publish-docs" jobs to use dotNetJob helper, removing manual checkout and SDK setup |
| .github/workflows/release.yml | Generated workflow now includes standardized env vars, SDK setup without explicit version, and NuGet caching |
| .github/workflows/docs.yml | Generated workflow now uses SDK version from global.json instead of hardcoded "8.x", adds NuGet caching |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ForNeVeR
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.