Fix hardcoded camera preview aspect ratio in /setup and /calibrate #242
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small UI fix for the /setup and /calibrate pages.
The camera preview on those pages is hardcoded to 600x338px, aspect ratio 16:9. My camera's max resolution is 1280x960, aspect ratio 4:3. The preview is therefore cropped. I didn't realise this when setting up my system and I accidentally chose 1280x720 for the camera since there's no difference between the 2 options in the preview.
This PR changes that so the dimensions are read from the camera and the height of the iframe is adjusted accordingly.