fix: excludeQuery for get balance by currency#165
fix: excludeQuery for get balance by currency#165umar-abdullahi wants to merge 2 commits intoFlutterwave:masterfrom
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15791508 | Triggered | Generic High Entropy Secret | ea494e6 | test/rave.transactions.test.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
The currency param in getBalanceByCurrency endpoint is a path param and not a query string.
The current implementation creates a query string like this
/v3/balances/NGNcurrency:NGNinstead of/v3/balances/NGNso the endpoint always return "balance does not exist for this currency"