Open
Conversation
…iOS >= 11 (TextureGroup#2003) `flipsHorizontallyInOppositeLayoutDirection` is available in iOS11 and greater. Texture still supports iOS9 so we need to make sure not to call this it in those cases.
… collision (TextureGroup#2020) As of iOS15 the AuthenticationServices framework has a class named `ASNavigationController`. We need to rename our `ASNavigationController` to protect against undefined behavior. Note: This change was based on this PR TextureGroup#2014. We were slow in merging it and the author has not replied, so I'm making a new one to get this landed.
With the breaking change of renaming ASNavigationController to ASDKNavigationController, we have released a new version of Texture. Please see `ThreeMigrationGuide.md` for how to handle the breaking changes in 3.1.0.
- The framework isn't available on tvOS. This causes CocoaPods linting to fail which prevented me from pushing the new release out. - One way to fix this is to have a different `default_subspecs` for tvOS that doesn't have AssetsLibrary subspec, but per-platform `default_subspecs` doesn't seem to be supported by CocoaPods. So I updated the subspec itself to only depend on the framework for iOS. This means the subspec is empty/useless for tvOS (and other platforms FWIW). - Tested with `pod spec lint Texture.podspec`. - Fixes TextureGroup#1992 and part of TextureGroup#1549. Also unblocks 3.1.0 release. - For the long term, we can remove the subspec entirely when iOS 9 is deprecated (TextureGroup#1828).
It looks like github updated so that `macos-latest` is now macos-11. It can't find Xcode_11_5. Let's try to set the runs-on version explicitly and see if some magic happens. also allow warnings for podlint because that started failing too
TextureGroup#2032) * replace destructor for after main execute * separate ASLoadFrameworkInitializer between constructor and destructor * AS_EXTERN -> ASDK_EXTERN * initialSetNeedsDisplayCount should be called once on iOS 15 * Loaded node of contentsScale must be 2.0 on layer backed * initialSetNeedsDisplayCount must called once
…extureGroup#2050) In PR 2032 we added alloc/dealloc texture initialization methods for the case where texture is automatically initializing. However, in doing so we have removed the `ASInitializeFrameworkMainThread` method that clients may already be using. This PR brings back the `ASInitializeFrameworkMainThread` to live side by side with `ASInitializeFrameworkMainThreadOnConstructor` and `ASInitializeFrameworkMainThreadOnDestructor`. This should keep the old functionality in place for any client using `ASInitializeFrameworkMainThread` directly.
…ache (TextureGroup#2075) While NSCache is thread safe, that alone does not make `rendererForAttributes` thread safe. This experiment will add a lock to `rendererForAttributes` to see how that affects performance/stability. As second experiment will forego the cache altogether to validate that we are getting some value out of having a renderer cache.
…existent) to ASDKViewController/ASDKNavigationController (TextureGroup#2072) * Fix references of ASViewController (non-existent) to ASDKViewController * More references changes to old ASViewController * Also update ASNavigationController -> ASDKNavigationController
* Try to get CI to work * update to xcode that exists * Use a more recent sim; update podfiles not to use github as source * fix clang 10 error about 10 being extern * don’t override deprecated method * Fix tests and snapshot tests
…tureGroup#2084) We have `ASCellNodeVisibilityEvent` events that roughly correlate to the scrollViewDid… delegate methods in UIScrollView. With the current events we get a callback when a user stops dragging a cell, but if the cell decelerates we do not get an event when it comes to a rest. I’ve added `ASCellNodeVisibilityEventDidStopScrolling` to have both `ASTableView` and `ASCollectionView` send this event to the cells in `_cellsForVisibilityUpdates` in `- (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView`. I created unit tests to ensure that the proper events are being called for the proper scroll delegate methods.
* Fix build errors and a crash in xcode 15 * early return if 0 or negative dimensions found
* Update to Xcode 15 We want to make Texture build with recent tools like Xcode 15. Part of this is bumping the minimum supported OS to iOS 14. I only removed the dead code (i.e. code gated on versions older than iOS 14). There are still some warnings about outdated APIs in use, but they are non-trivial changes to fix. Run all the examples. Run all the unit tests and make them pass. * Use Xcode 15.3 so we have 17.4 simulators * Fixing an asset catalog compiler error when building against iPhone SE * Fix a couple of file extensions for assets A couple of PNGs were marked as JPGs
## Summary Following RELEASE.md steps, bump to 3.2.0.
…d transform (TextureGroup#2116) There is built in protection around setting invalid bounds for `_ASDisplayLayer`. Let’s extend this to also include protecting against setting an invalid position and an invalid transform.
Co-authored-by: rqueue <ryanhquan@gmail.com> Co-authored-by: Andrew Yates <contact@andydev.co.uk> Co-authored-by: rqueue <rquan@pinterest.com> Co-authored-by: Sylvain Defresne <sdefresne@gmail.com> Co-authored-by: ricky <ricky@pinterest.com> Co-authored-by: Huy Nguyen <huy@pinterest.com> Co-authored-by: David Ha <h2s1880@gmail.com> Co-authored-by: Mussa Charles <mussacharles50@gmail.com> Co-authored-by: Garrett Moon <garrett@pinterest.com> Co-authored-by: Joe Ferrucci <2114494+JoeFerrucci@users.noreply.github.com> Co-authored-by: Koichiro Ueki <43738558+Ueeek@users.noreply.github.com> Co-authored-by: Carlos Compean <cacmartinez@msn.com> Co-authored-by: Andy Finnell <andyfinnell@mac.com> Co-authored-by: Gabriel Liévano <811827+rgnns@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review should only be done on last commit