BUGFIX: ElasticSearchQueryBuilder removes json encode generated quotes#400
Open
gjwnc wants to merge 1 commit intoFlowpack:mainfrom
Open
BUGFIX: ElasticSearchQueryBuilder removes json encode generated quotes#400gjwnc wants to merge 1 commit intoFlowpack:mainfrom
gjwnc wants to merge 1 commit intoFlowpack:mainfrom
Conversation
Contributor
Author
|
I just noticed, that this issues is mentioned here #311 . Since, it could depend on the use case, both PR's might be considered independent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the ES CR Adaptor uses query_string which allows some search syntax in query string.
In the current implementation,
json_encodeis used on the query string which adds double quotes around the search term,e.g.
brown foxis json encoded to"brown fox". Thentrimis used to remove the".Since one can use double quotes in the search term itself, e.g.
quick "brown fox"this results in json encoded"quick \"brown fox\"". If you usetrimyou get invalid json which causes an exception because of invalid syntax in the ES query:quick \"brown fox\.This PR, just removes the outer quotes created by
json_encode.