Open
Conversation
Author
|
Simplified example: public function getVehiclePages(NodeInterface $siteNode)
{
$filter = [
'Foo.Bar:Document.Vehicle',
'Foo.Bar:Document.Motorcyle',
'!Neos.Neos:Document' // this nodetype will be excluded
];
$queryBuilder = new ElasticSearchQueryBuilder();
$queryBuilder->query($siteNode);
$queryBuilder->nodeTypeFilter(implode(',', $filter));
// [...]
} |
erkenes
force-pushed
the
feature/ee-nodetype-filter
branch
from
e9b1557 to
c750f23
Compare
Author
|
@Sebobo @daniellienert can you review this PR? |
kitsunet
reviewed
Feb 16, 2023
erkenes
force-pushed
the
feature/ee-nodetype-filter
branch
from
c750f23 to
b699e46
Compare
Contributor
daniellienert
left a comment
daniellienert
left a comment
There was a problem hiding this comment.
Hey @erkenes, thanks a lot for the improvement!
I have two comments tho.
Cheers Daniel
| */ | ||
| public function nodeTypeFilter(array $expectedNodeTypes, array $excludedNodeTypes): QueryBuilderInterface | ||
| { | ||
| $excludeShould = []; |
Contributor
There was a problem hiding this comment.
Nitpick: It ends in an bool must / must_not query so should is a bit missleading here
| * @throws QueryBuildingException | ||
| * @api | ||
| */ | ||
| public function nodeTypeFilter(array $expectedNodeTypes, array $excludedNodeTypes): QueryBuilderInterface |
Contributor
There was a problem hiding this comment.
Would be nice if you would add a slim test in ElasticSearchQueryTest.
Author
There was a problem hiding this comment.
I added a test and adjusted the existing tests to match the new circumstances.
- Creates a method which allows to create a nodetype filter to include and exclude specific nodetypes - Adds a test for the new filter function - Adjusts existing tests to match the new circumstances
erkenes
force-pushed
the
feature/ee-nodetype-filter
branch
from
b699e46 to
2b66844
Compare
erkenes
requested review from
daniellienert
and removed request for
kitsunet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a method which allows to create a nodetype filter to include and exclude specific nodetypes