Skip to content

fix(components): add missing opik key to returnIds in AnalyticHandler.onLLMStart#6006

Merged
HenryHengZJ merged 1 commit intoFlowiseAI:mainfrom
wishhyt:bugfix/fix-opik-missing-in-llmstart-returnids
Mar 19, 2026
Merged

fix(components): add missing opik key to returnIds in AnalyticHandler.onLLMStart#6006
HenryHengZJ merged 1 commit intoFlowiseAI:mainfrom
wishhyt:bugfix/fix-opik-missing-in-llmstart-returnids

Conversation

@wishhyt
Copy link
Contributor

@wishhyt wishhyt commented Mar 18, 2026

Summary

AnalyticHandler.onLLMStart() in packages/components/src/handler.ts initializes a returnIds object that is missing the opik: {} entry. When the Opik analytics provider is enabled, the code later attempts to set returnIds['opik'].llmSpan, which throws TypeError: Cannot set properties of undefined (setting 'llmSpan').

All sibling methods (onChainStart, onToolStart) correctly include opik in their returnIds initialization. This was a copy-paste omission.

Changes

Added opik: {} to the returnIds object in onLLMStart() (line 1312)

How to reproduce the bug

  1. Configure Opik as an analytics provider in a chatflow
  2. Trigger a prediction that invokes LLM
  3. onLLMStart throws TypeError, breaking analytics tracking

The onLLMStart method in AnalyticHandler was missing the `opik: {}` entry
in its returnIds object initialization, while the code at line 1431
accesses returnIds['opik'].llmSpan. This caused a TypeError when opik
analytics provider was enabled.

All other methods (onChainStart, onToolStart) correctly include opik in
their returnIds. This was a copy-paste omission.

Made-with: Cursor
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the 'AnalyticHandler' component where the Opik analytics provider was not correctly initialized, leading to a runtime error. The fix ensures that the 'onLLMStart' method properly includes the 'opik' key in its 'returnIds' object, aligning its behavior with other similar methods and preventing analytics tracking failures.

Highlights

  • Bug Fix: Opik Analytics Initialization: Resolved a TypeError occurring when the Opik analytics provider was enabled due to a missing 'opik: {}' entry in the 'returnIds' object within 'AnalyticHandler.onLLMStart()'.
  • Improved Analytics Stability: Ensured consistent initialization of analytics provider IDs across 'AnalyticHandler' methods, preventing runtime errors and ensuring proper analytics tracking for Opik.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a TypeError that occurred when using the Opik analytics provider by adding a missing opik key during the initialization of the returnIds object. The fix is appropriate and resolves the described bug. The suggestion to refactor the duplicated object initialization into a helper method has been omitted, as for small, clear configurations, duplication is acceptable if the maintainability benefit is negligible, aligning with repository guidelines.

@HenryHengZJ HenryHengZJ merged commit ff875b9 into FlowiseAI:main Mar 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants