Skip to content

fix(components): add missing regex handler to Condition node#5651

Merged
HenryHengZJ merged 4 commits intoFlowiseAI:mainfrom
Aadil-Hasun:bugfix/condition-regex-operation
Feb 26, 2026
Merged

fix(components): add missing regex handler to Condition node#5651
HenryHengZJ merged 4 commits intoFlowiseAI:mainfrom
Aadil-Hasun:bugfix/condition-regex-operation

Conversation

@Aadil-Hasun
Copy link
Contributor

Summary

Fixes #5650 - The Regex operation in Condition node was not implemented.

Changes

  • Added [regex]
    Flowise/packages/components/nodes/agentflow/Condition/Condition.ts:277:12-297:13) handler to compareOperationFunctions
  • Added [unescapeRegexPattern]
    Flowise/packages/components/nodes/agentflow/Condition/Condition.ts:278:16-288:17) helper to handle Flowise's escaping of metacharacters
  • Gracefully returns false for invalid regex patterns (no crashes)
  • Added 22 unit tests covering all scenarios

Test Coverage

  • All regex metacharacters: ^ $ [ ] . * + ? { } ( ) |
  • Flowise escaping scenarios
  • Invalid patterns (graceful failure)
  • Edge cases (null, empty values)

Known Limitation

Patterns matching markdown link syntax may be affected by existing removeMarkdown preprocessing.

The Condition agentflow node's Regex operation was not functional because
compareOperationFunctions was missing the regex handler.
Changes:
- Added regex handler with unescapeRegexPattern helper function
- Handles Flowise's escaping of regex metacharacters
- Gracefully returns false for invalid regex patterns
- Added 22 unit tests
Fixes FlowiseAI#5650
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Aadil-Hasun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical missing feature in the Condition node within Agentflow by integrating a robust regular expression comparison handler. The implementation accounts for Flowise's automatic input escaping, ensuring that user-defined regex patterns are correctly interpreted. Furthermore, it enhances system stability by gracefully managing invalid regex inputs and is backed by a comprehensive suite of unit tests to guarantee reliability across various scenarios.

Highlights

  • Regex Handler Added: A new regex comparison operation has been implemented and added to the Condition node, enabling regular expression matching for conditional logic.
  • Flowise Escaping Handled: An unescapeRegexPattern helper function was introduced to correctly interpret regex patterns that Flowise's input handling might have automatically escaped (e.g., \[ for [).
  • Graceful Error Handling: The implementation now gracefully handles invalid regex patterns, preventing crashes and returning false for such cases.
  • Comprehensive Unit Tests: Twenty-two new unit tests have been added to ensure robust coverage of the regex functionality, including various metacharacters, Flowise-specific escaping scenarios, edge cases, and invalid patterns.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds the missing regex operation to the Condition node, including a comprehensive set of unit tests. The implementation correctly handles escaped characters from the Flowise UI and gracefully manages invalid regex patterns. My review includes a few suggestions to improve the implementation's correctness and robustness, as well as enhance the consistency and completeness of the new tests. Specifically, I've pointed out a potential bug in the regex unescaping logic and suggested improvements to the test structure and assertions.

- Move unescapeRegexPattern to module level for performance
- Restrict unescaping to only [, ], * (verified by UI testing)
- Use nodeClass from beforeEach in all tests for consistency
- Add else condition assertions for non-matching tests
- Add test for escaped asterisk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: "Regex" operation in Condition node is not implemented in backend

2 participants