Skip to content

refactor: add method that receives class instead of instance #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paodb merged 1 commit into from
Apr 30, 2026
Merged

refactor: add method that receives class instead of instance #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions base/src/main/java/com/flowingcode/vaadin/addons/demo/DefaultSourceUrlResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ public class DefaultSourceUrlResolver implements SourceUrlResolver {
@Override
public Optional<String> resolveURL(TabbedDemo demo, Class<?> annotatedClass,
DemoSource annotation) {
return resolveURL(demo.getClass(), annotatedClass, annotation);
}

public Optional<String> resolveURL(Class<? extends TabbedDemo> viewClass, Class<?> annotatedClass,
DemoSource annotation) {
String demoFile;
String url = annotation.value();
if (url.equals(DemoSource.DEFAULT_VALUE)) {
Expand All @@ -57,8 +62,8 @@ public Optional<String> resolveURL(TabbedDemo demo, Class<?> annotatedClass,
}

if (demoFile != null) {
String branch = TabbedDemo.lookupGithubBranch(demo.getClass());
return Optional.ofNullable(demo.getClass().getAnnotation(GithubLink.class))
String branch = TabbedDemo.lookupGithubBranch(viewClass);
return Optional.ofNullable(viewClass.getAnnotation(GithubLink.class))
.map(githubLink -> String.format("%s/blob/%s/%s", githubLink.value(), branch, demoFile));
} else {
return Optional.empty();
Expand Down
Loading