Pulling in submodules: <ipc_shm: Fix egregiously hidden and sneaky bug/typo in SHM-classic ipc::shm::classic::Pool_arena::construct(), which also potentially affects other consumers of SHM-classic, directly or otherwise: sometimes the memory taken from a reserved SHM-pool in SHM-classic was a few bytes fewer than actually necessary, leading to unpredictable behavior for certain object sizes. / Fixed small bug wherein SHM-classic ipc::shm::classic::Pool_arena logged as-if from component TRANSPORT instead of the correct component SHM. / In SHM-classic ipc::shm::classic::Pool_arena a couple internal changes for small memory/perf improvements: the boost.ipc index is unnecessary and is now omitted; and avoid a certain heap allocation. / Minor. (Opportunistic.)>#147
Merged
Pulling in submodules: <ipc_shm: Fix egregiously hidden and sneaky bug/typo in SHM-classic ipc::shm::classic::Pool_arena::construct(), which also potentially affects other consumers of SHM-classic, directly or otherwise: sometimes the memory taken from a reserved SHM-pool in SHM-classic was a few bytes fewer than actually necessary, leading to unpredictable behavior for certain object sizes. / Fixed small bug wherein SHM-classic ipc::shm::classic::Pool_arena logged as-if from component TRANSPORT instead of the correct component SHM. / In SHM-classic ipc::shm::classic::Pool_arena a couple internal changes for small memory/perf improvements: the boost.ipc index is unnecessary and is now omitted; and avoid a certain heap allocation. / Minor. (Opportunistic.)>#147
ipc::shm::classic::Pool_arena::construct(), which also potentially affects other consumers of SHM-classic, directly or otherwise: sometimes the memory taken from a reserved SHM-pool in SHM-classic was a few bytes fewer than actually necessary, leading to unpredictable behavior for certain object sizes. / Fixed small bug wherein SHM-classic ipc::shm::classic::Pool_arena logged as-if from component TRANSPORT instead of the correct component SHM. / In SHM-classic ipc::shm::classic::Pool_arena a couple internal changes for small memory/perf improvements: the boost.ipc index is unnecessary and is now omitted; and avoid a certain heap allocation. / Minor. (Opportunistic.)>#147Conversation
…g/typo in SHM-classic `ipc::shm::classic::Pool_arena::construct()`, which also potentially affects other consumers of SHM-classic, directly or otherwise: sometimes the memory taken from a reserved SHM-pool in SHM-classic was a few bytes fewer than actually necessary, leading to unpredictable behavior for certain object sizes. / Fixed small bug wherein SHM-classic `ipc::shm::classic::Pool_arena` logged as-if from component TRANSPORT instead of the correct component SHM. / In SHM-classic `ipc::shm::classic::Pool_arena` a couple internal changes for small memory/perf improvements: the boost.ipc index is unnecessary and is now omitted; and avoid a certain heap allocation. / Minor. (Opportunistic.)>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Flow-IPC/ipc_shm#29
To code reviewer
Forgoing code review, because it is only pulling in submodule change(s) with their own PR(s).