(SHM-jemalloc) Removed an INFO-severity logged message that is logged from ipc::shm::arena_lend::jemalloc::Ipc_arena::get_collection_id(), a public API but more likely invoked internally from Shm_session::lend_object() which can be oft-used directly and/or for each capnp-encoded message sent through a SHM-jemalloc-backed ipc::transport::struc::Channel. / Use move-semantics in a few places internally to avoid unnecessary shared_ptr ref-count arithmetic. / Effectively remove a few redundant internal assert()s. / Comment and/or doc changes.#144
Merged
(SHM-jemalloc) Removed an INFO-severity logged message that is logged from ipc::shm::arena_lend::jemalloc::Ipc_arena::get_collection_id(), a public API but more likely invoked internally from Shm_session::lend_object() which can be oft-used directly and/or for each capnp-encoded message sent through a SHM-jemalloc-backed ipc::transport::struc::Channel. / Use move-semantics in a few places internally to avoid unnecessary shared_ptr ref-count arithmetic. / Effectively remove a few redundant internal assert()s. / Comment and/or doc changes.#144
ipc::shm::arena_lend::jemalloc::Ipc_arena::get_collection_id(), a public API but more likely invoked internally from Shm_session::lend_object() which can be oft-used directly and/or for each capnp-encoded message sent through a SHM-jemalloc-backed ipc::transport::struc::Channel. / Use move-semantics in a few places internally to avoid unnecessary shared_ptr ref-count arithmetic. / Effectively remove a few redundant internal assert()s. / Comment and/or doc changes.#144Conversation
… code new to me; but perf-relevant, could be significant) Removed an INFO-severity logged message that is logged from `ipc::shm::arena_lend::jemalloc::Ipc_arena::get_collection_id()`, a public API but more likely invoked internally from `Shm_session::lend_object()` which can be oft-used directly and for each capnp-encoded message sent through a SHM-jemalloc-backed `ipc::transport::struc::Channel`. / (opportunistically found while grokking code new to me; but somewhat perf-relevant) Use move-semantics in a few places internally to avoid unnecessary `shared_ptr` ref-count arithmetic. / (opportunistically found while grokking code new to me; but slightly perf-relevant if asserts-on) Effectively remove a few redundant internal `assert()`s. / Comment and/or doc changes. (Opportunistic.)>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To code reviewer
Forgoing code review, as this is a bundling of other PRs via submodules (actually 1 PR/submodule).