ipc::transport::struc::Channel API now formally allows concurrent calls of its APIs on the same object including .sync_request(). .sync_request()s will execute fully serially, even if a blocking-wait is necessary; but any other call during a .sync_request() blocking-wait shall execute immediately. / ipc::session::shm::arena_lend::jemalloc::Shm_session internal improvement (no effect on functionality).#141
Merged
ipc::transport::struc::Channel API now formally allows concurrent calls of its APIs on the same object including .sync_request(). .sync_request()s will execute fully serially, even if a blocking-wait is necessary; but any other call during a .sync_request() blocking-wait shall execute immediately. / ipc::session::shm::arena_lend::jemalloc::Shm_session internal improvement (no effect on functionality).#141
ipc::transport::struc::Channel API now formally allows concurrent calls of its APIs on the same object including .sync_request(). .sync_request()s will execute fully serially, even if a blocking-wait is necessary; but any other call during a .sync_request() blocking-wait shall execute immediately. / ipc::session::shm::arena_lend::jemalloc::Shm_session internal improvement (no effect on functionality).#141Conversation
…now formally allows concurrent calls of its APIs on the same object including `.sync_request()`. `.sync_request()`s will execute fully serially, even if a blocking-wait is necessary; but any other call during a `.sync_request()` blocking-wait shall execute immediately.> <ipc_sal: `ipc::session::shm::arena_lend::jemalloc::Shm_session` internal improvement (no effect on functionality). (Impl: No need to explicitly synchronize the internal-channel `.sync_request()` calls, as the `Channel` API now guarantees this itself.)>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Flow-IPC/ipc_shm_arena_lend#61
API notes
ipc::transport::struc::Channelmethods now all safe for mutually concurrent execution on the same object (was only the case for certain accessors and.create_msg()previously).X.sync_request()blocking-wait, all (non-blocking) methods onXshall execute immediately.X.sync_request()shall be blocked until the blocking-wait finishes.Impl notes
.sync_request()calls, as theChannelAPI now guarantees this itself.To code reviewer
Forgoing code review, because submodule PRs already reviewed.