Skip to content

Fix PyTorch Sylvester complex shortcut#2496

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-pytorch-sylvester-complex-shortcut
May 31, 2026
Merged

Fix PyTorch Sylvester complex shortcut#2496
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-pytorch-sylvester-complex-shortcut

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Restrict the PyTorch solve_sylvester symmetric fast path to real shared symmetric factors.
  • Route complex symmetric non-Hermitian inputs through the general SciPy Sylvester solver.
  • Add a regression test that checks the residual for a complex symmetric non-Hermitian case.

Validation

Local numerical check: the old shortcut has a residual norm around 3.04 on the regression case, while the patched path is around 1e-15.

@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 45.66s
✅ JSON prettier 7 0 0 0 1.13s
✅ JSON v8r 7 0 0 4.64s
✅ MARKDOWN markdownlint 66 0 0 0 1.74s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.78s
✅ PYTHON black 781 0 0 0 35.81s
✅ PYTHON isort 781 0 0 0 5.98s
✅ REPOSITORY checkov yes no no 41.78s
✅ REPOSITORY gitleaks yes no no 12.71s
✅ REPOSITORY git_diff yes no no 0.12s
✅ REPOSITORY secretlint yes no no 22.56s
✅ REPOSITORY syft yes no no 4.97s
✅ REPOSITORY trivy-sbom yes no no 5.54s
✅ REPOSITORY trufflehog yes no no 21.99s
✅ YAML prettier 11 0 0 0 0.67s
✅ YAML v8r 11 0 0 11.08s
✅ YAML yamllint 11 0 0 0.4s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 31, 2026 10:05
@FlorianPfaff FlorianPfaff merged commit febeea3 into main May 31, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant