Conversation
Implement config-driven include overrides and profile-scoped include/exclude extensions so users can re-include paths normally excluded by ignore_patterns, .gitignore, or default excludes without editing .gitignore or weakening global excludes. Changes: - config.py: Add include_patterns to DEFAULT_CONFIG, validate new fields (include_patterns, profile additional_excludes/additional_includes) - core.py: Add included_patterns support to DumpSession with _is_force_included helper that checks both pathspec matching and directory ancestor traversal - engine.py: Merge top-level and profile include/exclude lists in _initialize_session, pass effective includes to DumpSession - Add 45 comprehensive tests covering validation, behavior, engine integration, regression, and force-include helper logic https://claude.ai/code/session_01U9Lzb7fYHLCXcBuWao1px1
Summary of ChangesHello @FloLey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a flexible system for overriding file exclusion rules, allowing users to explicitly re-include files or directories that would otherwise be ignored by Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a powerful and well-designed override system for file inclusion/exclusion. The changes are logically structured across the configuration, core, and engine components. The new configuration options (include_patterns, additional_excludes, additional_includes) are properly validated. The core logic for force-inclusion in core.py, while intricate, is supported by an exceptionally comprehensive new test suite, which provides strong confidence in its correctness and robustness. The integration into the engine is also clean. I have one minor suggestion to refactor a small piece of duplicated validation logic for improved maintainability. Overall, this is an excellent and high-quality contribution.
| if "additional_excludes" in body: | ||
| if not isinstance(body["additional_excludes"], list): | ||
| return False | ||
|
|
||
| if "additional_includes" in body: | ||
| if not isinstance(body["additional_includes"], list): | ||
| return False |
There was a problem hiding this comment.
The validation logic for additional_excludes and additional_includes is duplicated. You can refactor this into a loop to make the code more concise and easier to maintain if more list-based keys are added in the future.
| if "additional_excludes" in body: | |
| if not isinstance(body["additional_excludes"], list): | |
| return False | |
| if "additional_includes" in body: | |
| if not isinstance(body["additional_includes"], list): | |
| return False | |
| for key in ("additional_excludes", "additional_includes"): | |
| if key in body and not isinstance(body[key], list): | |
| return False |
Implement config-driven include overrides and profile-scoped include/exclude
extensions so users can re-include paths normally excluded by ignore_patterns,
.gitignore, or default excludes without editing .gitignore or weakening global
excludes.
Changes:
(include_patterns, profile additional_excludes/additional_includes)
helper that checks both pathspec matching and directory ancestor traversal
_initialize_session, pass effective includes to DumpSession
regression, and force-include helper logic
https://claude.ai/code/session_01U9Lzb7fYHLCXcBuWao1px1