Skip to content

chore(API): Bump clickhouse-driver to b33d5e7#7594

Open
khvn26 wants to merge 1 commit into
mainfrom
chore/bump-clickhouse-driver
Open

chore(API): Bump clickhouse-driver to b33d5e7#7594
khvn26 wants to merge 1 commit into
mainfrom
chore/bump-clickhouse-driver

Conversation

@khvn26
Copy link
Copy Markdown
Member

@khvn26 khvn26 commented May 25, 2026

Changes

Bumps the pinned clickhouse-driver revision in api/uv.lock to the current tip of the newjson branch.

How did you test this code?

  • uv lock --locked passes (lockfile is consistent with pyproject.toml).
  • git ls-remote https://github.com/Flagsmith/clickhouse-driver newjson confirms the SHA is the current branch tip.

@khvn26 khvn26 requested a review from a team as a code owner May 25, 2026 16:17
@khvn26 khvn26 requested review from emyller and removed request for a team May 25, 2026 16:17
@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 25, 2026 6:39pm
flagsmith-frontend-preview Ignored Ignored Preview May 25, 2026 6:39pm
flagsmith-frontend-staging Ignored Ignored Preview May 25, 2026 6:39pm

Request Review

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 25, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the clickhouse-driver dependency in the api/uv.lock file to a more recent commit hash on the newjson branch. There are no review comments to evaluate, and I have no feedback to provide.

@github-actions github-actions Bot added api Issue related to the REST API chore labels May 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7594 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7594 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api-test:pr-7594 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7594 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7594 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7594 Finished ✅ Results ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.51%. Comparing base (fe355be) to head (1c47d4c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7594   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files        1436     1436           
  Lines       54363    54363           
=======================================
  Hits        53553    53553           
  Misses        810      810

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  32.1 seconds
commit  fb8fb9d
info  🔄 Run: #16984 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  44.1 seconds
commit  fb8fb9d
info  🔄 Run: #16984 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  57.2 seconds
commit  fb8fb9d
info  🔄 Run: #16984 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  48.9 seconds
commit  fb8fb9d
info  🔄 Run: #16984 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.6 seconds
commit  e36a679
info  🔄 Run: #16986 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  44.2 seconds
commit  e36a679
info  🔄 Run: #16986 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  43.4 seconds
commit  e36a679
info  🔄 Run: #16986 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  42 seconds
commit  e36a679
info  🔄 Run: #16986 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39 seconds
commit  1c47d4c
info  🔄 Run: #16987 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43.5 seconds
commit  1c47d4c
info  🔄 Run: #16987 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.8 seconds
commit  1c47d4c
info  🔄 Run: #16987 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  60 seconds
commit  1c47d4c
info  🔄 Run: #16987 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026 •
edited
Loading

Visual Regression

19 screenshots compared. See report for details.
View full report

@github-actions github-actions Bot added chore and removed chore labels May 25, 2026
matthewelwell
matthewelwell previously approved these changes May 25, 2026
View reviewed changes
@khvn26 khvn26 force-pushed the chore/bump-clickhouse-driver branch from e36a679 to 1c47d4c Compare May 25, 2026 18:39
@github-actions github-actions Bot added chore and removed chore labels May 25, 2026
@khvn26 khvn26 changed the title chore(API): Bump clickhouse-driver to 76d60978 chore(API): Bump clickhouse-driver to b33d5e7 May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewelwell matthewelwell matthewelwell left review comments

@emyller emyller Awaiting requested review from emyller emyller is a code owner automatically assigned from Flagsmith/flagsmith-back-end

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api Issue related to the REST API chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khvn26 @matthewelwell