fix: feature pipeline status dark mode#7534
Draft
talissoncosta wants to merge 2 commits into
Draft
Conversation
Swap hardcoded `white`, `#AAA`, `#6837fc`, `#53af41` for semantic tokens so the stage circles and connector lines render correctly in dark mode (and align with the design system in light mode). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…eanup
- Lift environment lookup from StageStatus into FeaturePipelineStatus
via useGetEnvironmentsQuery; pass resolved envName as a prop so
StageStatus no longer depends on ProjectStore.
- Drop hardcoded `fill='#6837FC'` and `fill='#53af41'` on stage icons;
icons now inherit `currentColor` from `.in-stage` / `.completed`
modifiers on `.circle-container`.
- Replace inline `style={{ marginRight }}` with Bootstrap `me-0` /
`me-4` classNames.
- Use `<span>` instead of `<p>` for the env-name label so it sits
inline with the stage name.
- Remove duplicate `lastStage` / `isLastStage` variables.
- Swap `?? NaN` sentinel on `pipelineId` for `?? 0`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7018
The feature-pipeline status visualisation (circles + connector lines, rendered inside the Edit Feature modal when a feature is in a release pipeline) was broken in dark mode: white circles with grey
#AAAborders and lines sat on the dark surface as stark, off-token shapes. Blocker #6904 (semantic colour tokens) landed via #6883 on 2026-04-07, which unblocked this.Dark mode fix (
_feature-pipeline-status.scss)Hardcoded colours swapped for semantic tokens. No
.dark { ... }block needed —_tokens.scsspublishes dark-mode overrides for every semantic token, sovar(--color-*)adapts automatically.white(circle bg)var(--color-surface-default)--slate-0light,--slate-950dark#AAA(border / line)var(--color-border-default)#6837fc(in-stage)var(--color-border-action)--purple-600); lighter in dark (--purple-400) for contrast#53af41(completed)var(--color-border-success)--green-500(#27ab95) — visual shift, intentional under #6606.in-stage/.completedmodifiers also setcolor:so the stage icons inside can inherit viacurrentColor(see component cleanup below).Component cleanup (
StageStatus.tsx,FeaturePipelineStatus.tsx)While we were here:
ProjectStore(legacy Flux).StageStatususedProjectStore.getEnvironmentById()to render the env name. Lifted the lookup intoFeaturePipelineStatusviauseGetEnvironmentsQuery, passesenvNamedown as a prop.StageStatusis now pure / store-free / trivially testable.<Icon fill='#6837FC' />and<Icon fill='#53af41' />removed; icons default tocurrentColorand inherit from the.circle-containermodifier classes set in SCSS. Same colour-by-state mapping, no duplicated hex.style={{ marginRight: lastStage ? '0px' : '24px' }}→ Bootstrapme-0/me-4classNames.<span>instead of<p>for the env-name label so it sits inline with the stage name instead of forcing a block break.lastStage/isLastStage(same expression, twice).?? NaN→?? 0sentinel onpipelineId. Theskipguard means the value is never used, butNaNreads like leftover scaffolding.Deliberately not in scope
renderToString(<StageSummaryData />)workaround inStageStatus.Tooltip.tsxtypeschildren: stringand injects viadata-tooltip-html, so JSX has to be serialised. Fixing it means changing theTooltipAPI to acceptReactNode— wider change with cross-component impact. Worth a separate ticket.flexclassName. Verified it's a real project utility (web/styles/flexbox/_index.scss:3) that setsflex-direction: column. Layout depends on it.How did you test this code?
sdk_usage_chartsin the "Internal testing" stage of the Quick rollout pipeline).useGetEnvironmentsQuerylookup inFeaturePipelineStatusworks end-to-end.npx tsc --noEmit— no new type errors in the touched files.npx eslinton the touched files — clean.