Conversation
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
|
Important Testing in progress…🟢 UI Tests: 284 tests unchanged |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 284 tests unchanged |
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Visual Regression16 screenshots compared. See report for details. |
|
@claude review |
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, comment @claude review on this pull request to trigger a review.
|
@claude review |
There was a problem hiding this comment.
LGTM — straightforward additive feature-flag check using the existing Utils helper.
Extended reasoning...
Overview
This PR makes a single, small change to frontend/web/components/App.js: it adds Utils.getFlagsmithHasFeature('maintenance_mode') as an additional condition that triggers the <Maintenance /> screen, alongside the existing Project.maintenance, this.props.error, and !window.projectOverrides checks. The change is a 6-line additive modification with no other touched files.
Security risks
None apparent. The flag is read client-side via the existing Flagsmith feature-flag helper and only controls whether the maintenance UI is rendered — it does not affect authentication, authorization, data exposure, or any sensitive code path. Worst-case behavior of a misconfigured flag is showing the maintenance screen to users, which is the intended behavior.
Level of scrutiny
Low. This is a frontend-only chore-level change that follows an established pattern (toggling rendering based on a feature flag via Utils.getFlagsmithHasFeature). The author tested by enabling the flag on staging, all CI checks pass (Playwright OSS + private-cloud, Chromatic visual regression, Docker builds), and there is no logic complexity beyond an added boolean term in an OR expression.
Other factors
The author has explicitly requested review twice and no bugs were surfaced by the bug-hunting system. The change is self-contained, easy to revert, and has a clear, well-scoped intent.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Adds maintenance_mode flag as an option to turn on maintenance mode
How did you test this code?
Turned on the flag for the staging environment