Skip to content

fix(ui): replace misleading permission tooltip on segment override variations#7011

Open
nielskaspers wants to merge 1 commit intoFlagsmith:mainfrom
nielskaspers:fix/issue-6982-misleading-tooltip
Open

fix(ui): replace misleading permission tooltip on segment override variations#7011
nielskaspers wants to merge 1 commit intoFlagsmith:mainfrom
nielskaspers:fix/issue-6982-misleading-tooltip

Conversation

@nielskaspers
Copy link
Contributor

Summary

  • Fixes misleading "Create Feature permission" tooltip shown on read-only variation value inputs in segment overrides
  • When variations are read-only due to being in a segment override context, the tooltip now shows: "Variation values are defined at the feature level and cannot be changed per segment."
  • The original permission tooltip is preserved for cases where the user genuinely lacks Create Feature permission

Issue

Fixes #6982

Changes

  • frontend/web/components/mv/VariationValueInput.tsx: When readOnly is true and canCreateFeature is falsy, show an informative tooltip instead of the permission-related one

Testing

  1. Create a multivariate feature with variations
  2. Go to Segment Overrides tab
  3. Add or view a segment override
  4. Hover over a variation value input
  5. Verify the tooltip now says "Variation values are defined at the feature level and cannot be changed per segment."
  6. Verify that non-segment-override variation editing still shows the correct permission tooltip when the user lacks Create Feature permission

…riations (Flagsmith#6982)

When viewing segment overrides for multivariate features, variation value
inputs are read-only by design. The tooltip incorrectly suggested the user
lacked permissions. Now shows an informative message explaining that
variation values are set at the feature level.
@nielskaspers nielskaspers requested a review from a team as a code owner March 22, 2026 10:46
@nielskaspers nielskaspers requested review from talissoncosta and removed request for a team March 22, 2026 10:46
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link

vercel bot commented Mar 22, 2026

@nielskaspers is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Mar 22, 2026
@talissoncosta talissoncosta self-assigned this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading permission tooltip on read-only variation values in segment overrides

2 participants