fix(api): delegate concurrent deletion deadlocks to TaskBackoffError#6995
Open
SahilJat wants to merge 2 commits intoFlagsmith:mainfrom
Open
fix(api): delegate concurrent deletion deadlocks to TaskBackoffError#6995SahilJat wants to merge 2 commits intoFlagsmith:mainfrom
SahilJat wants to merge 2 commits intoFlagsmith:mainfrom
Conversation
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
|
@SahilJat is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6995 +/- ##
==========================================
- Coverage 98.31% 98.23% -0.09%
==========================================
Files 1335 1335
Lines 49784 49669 -115
==========================================
- Hits 48947 48793 -154
- Misses 837 876 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e7cf0a6 to
75004e5
Compare
41eb36b to
39aa2d6
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #6878
Please describe.
1.Wrapped the deletion queries in
environments/tasks.pyandfeatures/tasks.pywith specific exception handlers forOperationalError,IntegrityError, andTransactionManagementError.2. Delegated the retry mechanism by raising
TaskBackoffError.3. This allows the first worker to hold the lock and complete its softdelete cascade, while the colliding worker gracefully yields, backs off, and safely retries without polluting Sentry with unhandled DB exceptions.
How did you test this code?
Please describe.