Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
github-actions
bot
added
front-end
Contributor
Docker builds report
|
kyle-ssg
requested review from
a team and
Zaimwa9
and removed request for
a team
- Add data-test support to TableFilter component - Add data-test='table-filter-tags' to TableTagFilter - Replace manual page.locator() calls with helpers (click, clickByText, closeModal) - Add archived filter verification to flag tests - Remove redundant scrollIntoViewIfNeeded calls Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove all waitForTimeout calls from change-request, project, and versioning tests - Replace with proper wait helpers (waitForToast, waitForResponse, etc.) - Add "Use Helpers, Not Raw Page Methods" section to E2E context - Document all available wait and click helpers - Emphasize that helpers include proper waiting, error handling, and scrolling This makes tests more reliable and easier to maintain by using the established helper patterns. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
When archiving the only feature, the feature list becomes empty and filters disappear. Create an additional non-archived feature to ensure filters remain accessible when testing archived feature visibility. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
|
Contributor
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
Contributor
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Related #6562
How did you test this code?