Skip to content

chore: playwright#6562

Open
kyle-ssg wants to merge 262 commits intomainfrom
chore/playwright
Open

chore: playwright#6562
kyle-ssg wants to merge 262 commits intomainfrom
chore/playwright

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jan 20, 2026

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Playwright Test Improvements

Faster Tests

  • Inputs are really fast compared to TestCafe
  • Tests are passing in CI around 2m30s vs ~4m

Better Local Development

  • Tests are re-runable via ui (you'll have to run npm run test:teardown before clicking play again)
  • Tests come with videos and clickable traces (these get uploaded from GitHub on failures too)
  • Tests can be ran very quickly and can be repeated (E2E_REPEAT=x) and exit on first failed test (E2E_RETRIES=0)
image

main_large

Added Claude Commands

  • /e2e - Run all tests (OSS + Enterprise)
  • /e2e-oss - Run OSS tests, auto-fix failures, re-run until passing
  • /e2e-ee - Run Enterprise tests, auto-fix failures, re-run until passing
  • /e2e-create - Create a new test following existing patterns

Note: You can have the tests repeat to guarantee no flakiness

  • /e2e 5 → Runs all tests with E2E_REPEAT=5 (runs once, then 5 more times if passing)
  • /e2e-oss 5 → Same for OSS tests only
  • /e2e-ee 5 → Same for enterprise tests only
image

HTML Reports

  • Interactive dashboard with search/filter
  • Test timeline and duration metrics
  • Detailed error messages with stack traces

e.g. this is a downloaded report, we can access reports of failures as well as videos / interactive traces.

image image image image

CI/CD Features

GitHub Integration

  • Sticky PR comments with failure summaries
  • Direct links to ZIP artifacts containing:
  • HTML report
  • Videos of failures
  • Interactive traces
  • Screenshots
  • Automatic artifact cleanup
image image

How did you test this code?

  • No code changes, all e2e refactoring
  • Run local image and keep track of any failures
image

@kyle-ssg kyle-ssg requested a review from Zaimwa9 February 4, 2026 12:20
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  9 passed

Details

stats  9 tests across 7 suites
duration  41.5 seconds
commit  0613679
info  🔄 Run: #14783 (attempt 1)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  9 passed

Details

stats  9 tests across 7 suites
duration  1 minute, 2 seconds
commit  0613679
info  🔄 Run: #14783 (attempt 1)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  43.3 seconds
commit  0613679
info  🔄 Run: #14783 (attempt 1)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 4 seconds
commit  0613679
info  🔄 Run: #14783 (attempt 1)

Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to see all the tests green on my side. I have a couple of comments coming from making it happen with my setup.
I now use the docker-compose-e2e-tests, it's way more convenient than jungling with api + task processor.

Almost good to go on my side once you confirm.

@talissoncosta, I think a second review is worth here, especially to get familiar with the new setup and confirm we are all able to get the E2E suite to run on our locals

module.exports = [

new webpack.DefinePlugin({
E2E: process.env.E2E,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need it. I had to re-add it

Copy link
Member Author

@kyle-ssg kyle-ssg Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope we dont need this - why did you need to re-add it ?

npm run test

# Run with Playwright UI (for debugging)
npm run test:dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just precise that you need to build the bundle first with E2E=true npm run bundle here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need E2E=true anymore

kyle-ssg and others added 2 commits February 6, 2026 15:44
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
# Conflicts:
#	frontend/README.md
#	frontend/package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants