Conversation
…chore/componentise-feature-override-row # Conflicts: # frontend/web/components/feature-override/FeatureOverrideRow.tsx
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
|
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
|
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Zaimwa9
left a comment
There was a problem hiding this comment.
I'm happy to see all the tests green on my side. I have a couple of comments coming from making it happen with my setup.
I now use the docker-compose-e2e-tests, it's way more convenient than jungling with api + task processor.
Almost good to go on my side once you confirm.
@talissoncosta, I think a second review is worth here, especially to get familiar with the new setup and confirm we are all able to get the E2E suite to run on our locals
| module.exports = [ | ||
|
|
||
| new webpack.DefinePlugin({ | ||
| E2E: process.env.E2E, |
There was a problem hiding this comment.
I think we need it. I had to re-add it
There was a problem hiding this comment.
Nope we dont need this - why did you need to re-add it ?
| npm run test | ||
|
|
||
| # Run with Playwright UI (for debugging) | ||
| npm run test:dev |
There was a problem hiding this comment.
I would just precise that you need to build the bundle first with E2E=true npm run bundle here
There was a problem hiding this comment.
We dont need E2E=true anymore
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
# Conflicts: # frontend/README.md # frontend/package-lock.json
docs/if required so people know about the feature.Changes
Playwright Test Improvements
Faster Tests
Better Local Development
Added Claude Commands
/e2e- Run all tests (OSS + Enterprise)/e2e-oss- Run OSS tests, auto-fix failures, re-run until passing/e2e-ee- Run Enterprise tests, auto-fix failures, re-run until passing/e2e-create- Create a new test following existing patternsNote: You can have the tests repeat to guarantee no flakiness
HTML Reports
e.g. this is a downloaded report, we can access reports of failures as well as videos / interactive traces.
CI/CD Features
GitHub Integration
How did you test this code?