feat(utils): New is_database_replica_setup utility#100
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 94.51% 94.53% +0.02%
==========================================
Files 75 75
Lines 2408 2417 +9
==========================================
+ Hits 2276 2285 +9
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matthewelwell
previously approved these changes
Sep 4, 2025
khvn26
reviewed
Sep 4, 2025
khvn26
requested changes
Sep 4, 2025
Member
khvn26
left a comment
There was a problem hiding this comment.
I think we don't have to run this function every time it's called.
matthewelwell
previously approved these changes
Sep 4, 2025
88c2a04 to
28c3f19
Compare
matthewelwell
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to Flagsmith/flagsmith#5814
Add a new
is_database_replica_setuputility to help avoidingusing_database_replicawhen no replicas are given.