Skip to content

Fix segfault after package body drop #9031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Noremos wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −2
Open

Fix segfault after package body drop #9031

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e553a61
Remove MetadataCache routines for package body DFW
May 18, 2026
83884b8
Revert "Remove MetadataCache routines for package body DFW"
May 18, 2026
915f57c
Commit package body drop without CacheFlag::ERASED flag
May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/jrd/dfw.epp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2426,8 +2426,7 @@ static bool drop_package_body(thread_db* tdbb, SSHORT phase, DeferredWork* work,
case 6:
return true;
case 7:
routine = MetadataCache::getPerm<Cached::Package>(tdbb, work->dfw_id, CacheFlag::ERASED | CacheFlag::NOSCAN);
fb_assert(routine);
routine = MetadataCache::getPerm<Cached::Package>(tdbb, work->dfw_id, CacheFlag::NOSCAN);
if (routine)
Copy link
Copy Markdown
Member

@AlexPeshkoff AlexPeshkoff May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see MetadataCache::newVersionCached::Package() in CreatePackageBodyNode::execute(). It must have (as a pair) call to commit or rollback cache. Why did you decide to remove it?

Copy link
Copy Markdown
Contributor Author

@Noremos Noremos May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a moment, I thought the commit and rollback commands were only necessary for the erase and create operations. But as I see it now, the real problem is the invalid flag.

routine->commit(tdbb);
}
Expand Down
Loading