postfix(pag): Incorrect calculation of last used page when database contains only one PIP#8949
Open
TreeHunter9 wants to merge 2 commits intoFirebirdSQL:masterfrom
Open
postfix(pag): Incorrect calculation of last used page when database contains only one PIP#8949TreeHunter9 wants to merge 2 commits intoFirebirdSQL:masterfrom
TreeHunter9 wants to merge 2 commits intoFirebirdSQL:masterfrom
Conversation
Contributor
|
Because this PR is for master and master has C++20 enabled, consider using std::countl_zero in the loop above. |
Contributor
Author
I don't like the idea of adding some changes that doesn't belong to initial patch intent, especially when it comes to postfix patches, besides, this patch should be backported to v5. But the idea of using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postfix after #8772.