Skip to content

Big namespace cleanup#8930

Open
firebird-automations wants to merge 104 commits intomasterfrom
work/namespace-1
Open

Big namespace cleanup#8930
firebird-automations wants to merge 104 commits intomasterfrom
work/namespace-1

Conversation

@firebird-automations
Copy link
Collaborator

Put all namespaces inside the Firebird namespace.

Avoid qualification of namespace when inside it or in children namespaces.

Put *_proto.h headers in namespaces.

@aafemt
Copy link
Contributor

aafemt commented Mar 6, 2026

Move Why namespace inside Firebird
Move Replication namespace to Firebird::Jrd::Replication
Move namespace Ods to Firebird::Jrd::Ods

What's the purpose? It makes even less sense in company with "using namespace Firebird" everywhere.

It looks like you just wanna to kill every open PR with endless merge conflicts and build errors.

@AlexPeshkoff
Copy link
Member

Adriano please in a few words - why is "Put all namespaces inside the Firebird namespace" needed?

@asfernandes
Copy link
Member

Adriano please in a few words - why is "Put all namespaces inside the Firebird namespace" needed?

This has been discussed more than one time.

Did you see any other software written that uses many top level namespace? Not only in C++...

Did you think is correct to need to use :: Firebird everywhere outside common because it's well know fact that headers should not use using namespace?

Did you think it's correct to have part of the software not using namespaces and that adding namespace to it in the way they were being used would make point above even worse?

@aafemt
Copy link
Contributor

aafemt commented Mar 7, 2026

The sole purpose of namepaces is preventing conflict of names. Including everything into single namespace (global namespace with using namespace as well) completely defeats this purpose, and such usage of namespace Firebird was never discussed in firebird-devel list.

I wonder: was this PR made using AI?

@asfernandes
Copy link
Member

asfernandes commented Mar 7, 2026

Alex and others core developers:

In both times part of the proposals was what just I did here and that structure of namespaces had positive (certainly not negative) comments by Dmitry at least.

Or maybe the question is that 15 years was not sufficient time for the discussion to fully happen? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants