Conversation
What's the purpose? It makes even less sense in company with "using namespace Firebird" everywhere. It looks like you just wanna to kill every open PR with endless merge conflicts and build errors. |
|
Adriano please in a few words - why is "Put all namespaces inside the Firebird namespace" needed? |
This has been discussed more than one time. Did you see any other software written that uses many top level namespace? Not only in C++... Did you think is correct to need to use :: Firebird everywhere outside common because it's well know fact that headers should not use Did you think it's correct to have part of the software not using namespaces and that adding namespace to it in the way they were being used would make point above even worse? |
|
The sole purpose of namepaces is preventing conflict of names. Including everything into single namespace (global namespace with I wonder: was this PR made using AI? |
|
Alex and others core developers:
In both times part of the proposals was what just I did here and that structure of namespaces had positive (certainly not negative) comments by Dmitry at least. Or maybe the question is that 15 years was not sufficient time for the discussion to fully happen? :) |
Put all namespaces inside the Firebird namespace.
Avoid qualification of namespace when inside it or in children namespaces.
Put *_proto.h headers in namespaces.