Refactor benchmarks

.gitignore

@@ -6,3 +6,4 @@ bin
 obj
 out/
 .idea
+/BenchmarkDotNet.Artifacts

docs/benchmark.md

@@ -0,0 +1,120 @@
+# Benchmarks
+
+The benchmark project (`FirebirdSql.Data.FirebirdClient.Benchmarks`) measures performance of the Firebird .NET provider using [BenchmarkDotNet](https://benchmarkdotnet.org/).
+
+## Prerequisites
+
+- A running Firebird server accessible at `localhost` (default configuration)
+- .NET 10 SDK
+
+## Running Benchmarks
+
+Use the convenience script from the repository root:
+
+```powershell
+.\run-benchmark.ps1
+```
+
+By default this runs `CommandBenchmark`. To select a different benchmark class:
+
+```powershell
+.\run-benchmark.ps1 -Benchmark ConnectionBenchmark
+.\run-benchmark.ps1 -Benchmark LargeFetchBenchmark
+```
+
+### Advanced Options
+
+Enable JIT disassembly output:
+
+```powershell
+.\run-benchmark.ps1 -Disasm
+```
+
+Enable ETW profiling (Windows only):
+
+```powershell
+.\run-benchmark.ps1 -Profile
+```
+
+Options can be combined:
+
+```powershell
+.\run-benchmark.ps1 -Benchmark LargeFetchBenchmark -Disasm
+```
+
+### Running Directly with BenchmarkDotNet
+
+For full control over BenchmarkDotNet options, pass arguments directly after `--`:
+
+```powershell
+dotnet run --project src\FirebirdSql.Data.FirebirdClient.Benchmarks\FirebirdSql.Data.FirebirdClient.Benchmarks.csproj --configuration Release -- --list flat
+dotnet run --project src\FirebirdSql.Data.FirebirdClient.Benchmarks\FirebirdSql.Data.FirebirdClient.Benchmarks.csproj --configuration Release -- --filter "*Fetch*"
+```
+
+## Connection String
+
+By default the benchmark connects to:
+
+```
+database=localhost:benchmark.fdb;user=sysdba;password=masterkey
+```
+
+Override this with the `FIREBIRD_BENCHMARK_CS` environment variable:
+
+```powershell
+$env:FIREBIRD_BENCHMARK_CS = "database=myhost:benchmark.fdb;user=sysdba;password=masterkey"
+.\run-benchmark.ps1
+```
+
+## Configuration
+
+All benchmarks share a common configuration (`BenchmarkConfig`):
+
+- **Baseline job**: `ReleaseNuGet` build configuration — references the latest published `FirebirdSql.Data.FirebirdClient` NuGet package.
+- **Candidate job**: `Release` build configuration — references the local project source.
+- **Runtime**: .NET 10
+- **Diagnostics**: Memory allocations (`MemoryDiagnoser`)
+- **Export**: GitHub-flavored Markdown table (written to `BenchmarkDotNet.Artifacts/`)
+- **Ordering**: Fastest to slowest
+
+The NuGet baseline lets you compare the locally built provider against the published release to detect regressions or measure improvements.
+
+## Available Benchmarks
+
+### `CommandBenchmark`
+
+Measures command execution over two data types (`BIGINT`, `VARCHAR(10) CHARACTER SET UTF8`):
+
+| Benchmark | Description |
+|-----------|-------------|
+| `Execute` / `ExecuteAsync` | Inserts 100 rows using `ExecuteNonQuery` / `ExecuteNonQueryAsync` |
+| `Fetch` / `FetchAsync` | Reads 100 rows using `ExecuteReader` / `ExecuteReaderAsync` |
+
+### `ConnectionBenchmark`
+
+Measures connection pool throughput:
+
+| Benchmark | Description |
+|-----------|-------------|
+| `OpenClose` / `OpenCloseAsync` | Opens and closes a pooled connection |
+
+### `LargeFetchBenchmark`
+
+Measures bulk read throughput for 100,000 rows across five data types:
+
+| Data Type | Notes |
+|-----------|-------|
+| `BIGINT` | Fixed-size integer |
+| `CHAR(255) CHARACTER SET UTF8` | Fixed-length string |
+| `CHAR(255) CHARACTER SET OCTETS` | Fixed-length binary |
+| `BLOB SUB_TYPE TEXT CHARACTER SET UTF8` | Text blob |
+| `BLOB SUB_TYPE BINARY` | Binary blob |
+
+## Results
+
+BenchmarkDotNet writes results to `BenchmarkDotNet.Artifacts/` in the repository root. This directory is listed in `.gitignore`. Each run produces:
+
+- A summary table in the console
+- A GitHub-flavored Markdown file (`.md`) suitable for pasting into issues or pull requests
+- An HTML report
+- CSV data

docs/otel.md

@@ -0,0 +1,80 @@
+# OpenTelemetry Integration
+
+The Firebird ADO.NET provider includes built-in support for [OpenTelemetry](https://opentelemetry.io/) distributed tracing and metrics using the native .NET `System.Diagnostics` APIs. No dependency on the OpenTelemetry SDK is required in the provider itself — your application opts in by configuring the appropriate listeners.
+
+## Distributed Tracing
+
+The provider emits `Activity` spans for database command execution using `System.Diagnostics.ActivitySource`.
+
+### Enabling Traces
+
+```csharp
+using OpenTelemetry.Trace;
+
+var tracerProvider = Sdk.CreateTracerProviderBuilder()
+    .AddSource(FirebirdSql.Data.FirebirdClient.FbTelemetry.ActivitySourceName)
+    .AddConsoleExporter() // or any other exporter
+    .Build();
+```
+
+The `ActivitySource` name is `"FirebirdSql.Data"`, also available as the constant `FbTelemetry.ActivitySourceName`.
+
+### Span Attributes
+
+Spans follow the [OTel Database Client Semantic Conventions](https://opentelemetry.io/docs/specs/semconv/database/database-spans/):
+
+| Attribute | Description |
+|-----------|-------------|
+| `db.system.name` | Always `"firebirdsql"` |
+| `db.namespace` | The database name from the connection |
+| `db.operation.name` | The SQL verb (`SELECT`, `INSERT`, etc.) or `EXECUTE PROCEDURE` |
+| `db.collection.name` | The table name (for `TableDirect` commands) |
+| `db.stored_procedure.name` | The stored procedure name (for `StoredProcedure` commands) |
+| `db.query.summary` | A low-cardinality summary of the operation |
+| `db.query.text` | The full SQL text (**opt-in**, see below) |
+| `db.query.parameter.*` | Parameter values (**opt-in**, see below) |
+| `server.address` | The database server hostname |
+| `server.port` | The database server port (only when non-default, i.e. != 3050) |
+| `error.type` | The SQLSTATE code (for `FbException`) or exception type name |
+
+### Opt-In Sensitive Attributes
+
+By default, `db.query.text` and `db.query.parameter.*` are **not** collected, as they may contain sensitive data. Enable them explicitly:
+
+```csharp
+using FirebirdSql.Data.Logging;
+
+// Enable SQL text in traces
+FbLogManager.EnableQueryTextTracing();
+
+// Enable parameter values in traces (and logs)
+FbLogManager.EnableParameterLogging();
+```
+
+## Metrics
+
+The provider emits metrics via `System.Diagnostics.Metrics.Meter`.
+
+### Enabling Metrics
+
+```csharp
+using OpenTelemetry.Metrics;
+
+var meterProvider = Sdk.CreateMeterProviderBuilder()
+    .AddMeter(FirebirdSql.Data.FirebirdClient.FbTelemetry.MeterName)
+    .AddConsoleExporter() // or any other exporter
+    .Build();
+```
+
+The `Meter` name is `"FirebirdSql.Data"`, also available as the constant `FbTelemetry.MeterName`.
+
+### Available Metrics
+
+Metrics follow the [OTel Database Client Metrics Semantic Conventions](https://opentelemetry.io/docs/specs/semconv/database/database-metrics/):
+
+| Metric | Type | Unit | Description |
+|--------|------|------|-------------|
+| `db.client.operation.duration` | Histogram | `s` | Duration of database client operations |
+| `db.client.connection.create_time` | Histogram | `s` | Time to create a new connection |
+| `db.client.connection.count` | ObservableUpDownCounter | `{connection}` | Current connection count by state (`idle`/`used`) |
+| `db.client.connection.max` | ObservableUpDownCounter | `{connection}` | Maximum number of open connections allowed |

run-benchmark.ps1

@@ -0,0 +1,23 @@
+param(
+	[ValidateSet('CommandBenchmark','ConnectionBenchmark','LargeFetchBenchmark')]
+	$Benchmark = 'CommandBenchmark',
+
+	[switch]$Disasm,
+	[switch]$Profile
+)
+
+$ErrorActionPreference = 'Stop'
+
+$projectFile = '.\src\FirebirdSql.Data.FirebirdClient.Benchmarks\FirebirdSql.Data.FirebirdClient.Benchmarks.csproj'
+
+$extraArgs = @()
+if ($Disasm) { $extraArgs += '--disasm' }
+if ($Profile) { $extraArgs += '--profiler', 'ETW' }
+
+# Run selected benchmark
+dotnet run `
+    --project $projectFile `
+    --configuration 'Release' `
+    -- `
+    --filter "*$($Benchmark)*" `
+    @extraArgs

src/FirebirdSql.Data.FirebirdClient.Benchmarks/BenchmarkBase.cs

@@ -0,0 +1,41 @@
+/*
+ *    The contents of this file are subject to the Initial
+ *    Developer's Public License Version 1.0 (the "License");
+ *    you may not use this file except in compliance with the
+ *    License. You may obtain a copy of the License at
+ *    https://github.com/FirebirdSQL/NETProvider/raw/master/license.txt.
+ *
+ *    Software distributed under the License is distributed on
+ *    an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND, either
+ *    express or implied. See the License for the specific
+ *    language governing rights and limitations under the License.
+ *
+ *    All Rights Reserved.
+ */
+
+//$Authors = Jiri Cincura (jiri@cincura.net)
+
+using System;
+using BenchmarkDotNet.Attributes;
+
+namespace FirebirdSql.Data.FirebirdClient.Benchmarks;
+
+public abstract class BenchmarkBase
+{
+	const string DefaultConnectionString = "database=localhost:benchmark.fdb;user=sysdba;password=masterkey";
+
+	protected static readonly string ConnectionString =
+		Environment.GetEnvironmentVariable("FIREBIRD_BENCHMARK_CS") ?? DefaultConnectionString;
+
+	protected static void CreateDatabase(int pageSize = 16 * 1024)
+	{
+		FbConnection.CreateDatabase(ConnectionString, pageSize, false, true);
+	}
+
+	[GlobalCleanup]
+	public void GlobalCleanup()
+	{
+		FbConnection.ClearAllPools();
+		FbConnection.DropDatabase(ConnectionString);
+	}
+}

src/FirebirdSql.Data.FirebirdClient.Benchmarks/BenchmarkConfig.cs

@@ -0,0 +1,64 @@
+/*
+ *    The contents of this file are subject to the Initial
+ *    Developer's Public License Version 1.0 (the "License");
+ *    you may not use this file except in compliance with the
+ *    License. You may obtain a copy of the License at
+ *    https://github.com/FirebirdSQL/NETProvider/raw/master/license.txt.
+ *
+ *    Software distributed under the License is distributed on
+ *    an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND, either
+ *    express or implied. See the License for the specific
+ *    language governing rights and limitations under the License.
+ *
+ *    All Rights Reserved.
+ */
+
+//$Authors = Jiri Cincura (jiri@cincura.net)
+
+using BenchmarkDotNet.Configs;
+using BenchmarkDotNet.Diagnosers;
+using BenchmarkDotNet.Exporters;
+using BenchmarkDotNet.Jobs;
+using BenchmarkDotNet.Order;
+using BenchmarkDotNet.Toolchains;
+using BenchmarkDotNet.Toolchains.CsProj;
+using BenchmarkDotNet.Toolchains.DotNetCli;
+using BenchmarkDotNet.Validators;
+
+namespace FirebirdSql.Data.FirebirdClient.Benchmarks;
+
+class BenchmarkConfig : ManualConfig
+{
+	static readonly IToolchain Net100Toolchain =
+		CsProjCoreToolchain.From(new NetCoreAppSettings("net10.0", null, ".NET 10"));
+
+	public BenchmarkConfig()
+	{
+		var baseJob = Job.Default
+			.WithWarmupCount(3);
+
+		AddJob(
+			baseJob
+				.WithToolchain(Net100Toolchain)
+				.WithCustomBuildConfiguration("ReleaseNuGet")
+				.WithId("NuGet100")
+				.AsBaseline()
+		);
+
+		AddJob(
+			baseJob
+				.WithToolchain(Net100Toolchain)
+				.WithCustomBuildConfiguration("Release")
+				.WithId("Core100")
+		);
+
+		AddDiagnoser(MemoryDiagnoser.Default);
+
+		AddExporter(MarkdownExporter.GitHub);
+
+		Orderer = new DefaultOrderer(SummaryOrderPolicy.FastestToSlowest);
+
+		AddValidator(BaselineValidator.FailOnError);
+		AddValidator(JitOptimizationsValidator.FailOnError);
+	}
+}