feat: make firebaseServiceAccount input optional#398
Open
lucetre wants to merge 4 commits intoFirebaseExtended:mainfrom
Open
feat: make firebaseServiceAccount input optional#398lucetre wants to merge 4 commits intoFirebaseExtended:mainfrom
lucetre wants to merge 4 commits intoFirebaseExtended:mainfrom
Conversation
lucetre
commented
Dec 6, 2024
lucetre
commented
Dec 6, 2024
lucetre
commented
Dec 6, 2024
1 task
|
What happened to this? I would love to see this feature available |
Author
|
No updates yet @christopherL91, so I decided to use my cloned action in actual cases. It’s been working so far. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
The firebaseServiceAccount input is no longer required. If not provided, the action defaults to using the Application Default Credentials (ADC) available in the GitHub Actions environment. This reduces the need for explicitly managing and passing a service account key JSON file.
Expected Outcomes
By leveraging default credentials, this change minimizes the usage of static key JSON files, which can pose security risks if mishandled or exposed.
Users can now avoid creating and storing a firebaseServiceAccount secret unless explicitly needed, streamlining the setup process and reducing overhead.
Existing workflows that supply a firebaseServiceAccount key JSON will continue to function as before, with no changes required.