Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces hybrid AI inference capabilities by integrating Firebase AI On-Device and Firebase Performance Monitoring. Key changes include the addition of the generateIngredientsHybrid method in AIRemoteDataSource, which utilizes both cloud and on-device models based on Remote Config, and the implementation of loadOnDeviceModel to manage model downloads. Feedback focuses on optimizing resource usage by caching the GenerativeModel instance, improving error logging during model downloads, ensuring consistent suspension behavior when checking model status, and removing commented-out code to maintain codebase cleanliness.
...rc/main/java/com/google/firebase/example/friendlymeals/data/datasource/AIRemoteDataSource.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/firebase/example/friendlymeals/data/datasource/AIRemoteDataSource.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/firebase/example/friendlymeals/data/datasource/AIRemoteDataSource.kt
Show resolved
Hide resolved
app/src/main/java/com/google/firebase/example/friendlymeals/ui/generate/GenerateViewModel.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Mar 31, 2026
...rc/main/java/com/google/firebase/example/friendlymeals/data/datasource/AIRemoteDataSource.kt
Show resolved
Hide resolved
app/src/main/java/com/google/firebase/example/friendlymeals/ui/generate/GenerateViewModel.kt
Outdated
Show resolved
Hide resolved
thatfiredev
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces hybrid inference to extract ingredients from an image.