feat: standardise SP approval review tracking with issue template#28
Open
TippyFlitsUK wants to merge 1 commit intoFilOzone:masterfrom
Open
feat: standardise SP approval review tracking with issue template#28TippyFlitsUK wants to merge 1 commit intoFilOzone:masterfrom
TippyFlitsUK wants to merge 1 commit intoFilOzone:masterfrom
Conversation
Introduces a standard SP approval review issue template in tpm-utils and updates the approval runbook to use it as the source of truth. Removes duplicated field definitions from the runbook and ensures all SP approval reviews are tracked consistently with clear triggers, UTC timestamps, investigation windows, diagnosis, and outcomes. The template captures: - review trigger and timing - failing metrics and thresholds - investigation window and maintenance context - communication with SPs - diagnosis and classification of issues - decision, actions taken, and supporting evidence This improves operational consistency, auditability, and handover between approvers as we approach mainnet production readiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a standard SP approval review issue template in tpm-utils and updates the approval runbook to use it as the source of truth.
Removes duplicated field definitions from the runbook and ensures all SP approval reviews are tracked consistently with clear triggers, UTC timestamps, investigation windows, diagnosis, and outcomes.
The template captures:
This improves operational consistency, auditability, and handover between approvers as we approach mainnet production readiness.