Skip to content

fix(warm-storage): check metadata withCDN key in addition to cdnRailId for CDN status#505

Merged
hugomrdias merged 2 commits intomasterfrom
rvagg/withcdn
Dec 15, 2025
Merged

fix(warm-storage): check metadata withCDN key in addition to cdnRailId for CDN status#505
hugomrdias merged 2 commits intomasterfrom
rvagg/withcdn

Conversation

@rvagg
Copy link
Copy Markdown
Collaborator

@rvagg rvagg commented Dec 12, 2025

Fixes: #184

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Dec 12, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
synapse-dev 6ccb6a0 Dec 15 2025, 12:53 PM

Copy link
Copy Markdown
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me, tests would be nice to have

@rvagg
Copy link
Copy Markdown
Collaborator Author

rvagg commented Dec 15, 2025

tests added, linting failing cause of docs, maybe #507 fixes that

@hugomrdias hugomrdias merged commit db234e5 into master Dec 15, 2025
10 checks passed
@hugomrdias hugomrdias deleted the rvagg/withcdn branch December 15, 2025 12:40
@github-project-automation github-project-automation bot moved this from 📌 Triage to 🎉 Done in FOC Dec 15, 2025
lordshashank pushed a commit to lordshashank/synapse-sdk that referenced this pull request Mar 9, 2026
…d for CDN status (FilOzone#505)

Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Don't rely (just) on cdnRailId for withCDN check

3 participants