Hwx/fix 93 by kaola526 · Pull Request #95 · FilOzone/pdp-explorer

kaola526 · 2026-04-01T01:32:44Z

Make data_size optional in the SearchResult interface in apiService.ts
Remove data_size: '' from CID search result (no longer needed)
Update Landing.tsx to skip the additional info row for cid type results, preventing misleading 0.00 B display

Copilot

Pull request overview

This PR updates the subgraph client to better support Piece CID workflows by adding paginated/batched fetching for piece details and enabling CID-based navigation from the landing page search.

Changes:

Add first/skip pagination parameters to the pieceDetails GraphQL query and implement batched loading in usePiecePageData.
Update PieceDetails page to rely on the hook’s returned dataset list for pagination.
Extend search to recognize Piece CIDs and route users to the piece details page (including network-prefixed routes).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`subgraph-client/src/utility/queries.ts`	Adds pagination args to `pieceDetailsQuery` to enable batched retrieval.
`subgraph-client/src/hooks/usePiecePageData.tsx`	Implements batched fetching and deduplication for piece details data.
`subgraph-client/src/pages/PieceDetails.tsx`	Simplifies pagination inputs by using the hook’s returned `pieceDetails`.
`subgraph-client/src/api/apiService.ts`	Extends search result typing and adds CID result generation.
`subgraph-client/src/pages/Landing.tsx`	Adds CID navigation behavior and updates routes to include network prefix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T01:37:21Z

+                        {result.type === 'provider'
+                          ? `${result.active_sets} active sets`
+                          : result.type === 'root'
+                            ? `${result.total_roots} roots`
+                            : `${formatDataSize(result.data_size)}`}


For cid search results, data_size is currently set to an empty string, so this UI falls through to formatDataSize(result.data_size) and renders 0.00 B, which is misleading. Consider omitting the size row for cid results or making data_size optional and only rendering it for result types that actually have a meaningful size.

Copilot · 2026-04-01T01:37:22Z

 interface PiecePageOptions {
  activityLimit?: number
  retryOnError?: boolean
 }


activityLimit remains in PiecePageOptions but is no longer used after removing the weekly activity query. Either remove this option or reintroduce the behavior so the hook API matches what it actually does.

Copilot · 2026-04-01T01:37:22Z

+    if (cid) {
+      searchResults.push({
+        type: 'cid',
+        id: trimmedQuery,
+        data_size: '',
+      })
+    }


The cid search result is constructed with data_size: '' only to satisfy the type, which then propagates to the UI as a fake 0-byte size. Consider making data_size optional (or adding a dedicated field for CID results) and only setting it for result types where it’s meaningful.

@copilot apply changes based on this feedback

Done in commit 8bfb816. Made data_size optional in SearchResult, removed the data_size: '' from CID results, and updated Landing.tsx to skip the info row entirely for cid type results — so no more misleading 0.00 B display.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ID results Agent-Logs-Url: https://github.com/FilOzone/pdp-explorer/sessions/dc13e8c1-bc6d-4893-86b0-aac4599c16ba Co-authored-by: kaola526 <88829586+kaola526@users.noreply.github.com>

kaola526 · 2026-04-01T07:05:20Z

fix #93

beck-8 · 2026-04-01T09:07:51Z

@copilot re-review

beck-8 · 2026-04-01T09:08:41Z

I have no insight into the code. Someone else needs to be reviewed.
I was satisfied with the actual effect and did not see any problems.

silent-cipher

If we move the cid check earlier to handleSearch, we can simplify Landing.tsx by removing several ternaries.

Co-authored-by: Puspendra Mahariya <95584952+silent-cipher@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Puspendra Mahariya <95584952+silent-cipher@users.noreply.github.com>

kaola526

fixed

silent-cipher

I don’t see this addressed yet, nor any discussion on it.

My main concern is: why aren’t we checking for cid at the start of handleSearch? If the input is a cid, we could directly navigate to /${network}/piece/<cid> instead of going through search and then checking results && results[0].type === 'cid'.

The current flow introduces an unnecessary round trip and triggers an avoidable subgraph API call.

Refs - #95 (comment) , #95 (comment)

BigLep · 2026-04-08T05:05:04Z

@kaola526 : please re-request review when it's ready to be reviewed again?

kaola526 · 2026-04-08T07:06:53Z

@kaola526 : please re-request review when it's ready to be reviewed again?：等准备好再次审核时请重新请求审核？

The modifications have been made as requested. Please help review it again. Thank you.

Co-authored-by: Puspendra Mahariya <95584952+silent-cipher@users.noreply.github.com>

kaola526 added 2 commits March 31, 2026 20:13

fix #93

38de1bd

fix #93

de6d6c2

Copilot AI review requested due to automatic review settings April 1, 2026 01:32

FilOzzy added this to FOC Apr 1, 2026

github-project-automation bot moved this to 📌 Triage in FOC Apr 1, 2026

Copilot started reviewing on behalf of kaola526 April 1, 2026 01:33 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

kaola526 and others added 2 commits April 1, 2026 10:01

Update subgraph-client/src/pages/Landing.tsx

0d5893b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update subgraph-client/src/utility/queries.ts

77ddb35

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of kaola526 April 1, 2026 02:10 View session

Fix: make data_size optional in SearchResult; skip size display for C…

8bfb816

…ID results Agent-Logs-Url: https://github.com/FilOzone/pdp-explorer/sessions/dc13e8c1-bc6d-4893-86b0-aac4599c16ba Co-authored-by: kaola526 <88829586+kaola526@users.noreply.github.com>

Copilot finished work on behalf of kaola526 April 1, 2026 02:12

BigLep moved this from 📌 Triage to 🔎 Awaiting review in FOC Apr 1, 2026

BigLep assigned kaola526 Apr 1, 2026

rjan90 requested a review from silent-cipher April 1, 2026 09:51

silent-cipher requested changes Apr 1, 2026

View reviewed changes

github-project-automation bot moved this from 🔎 Awaiting review to ⌨️ In Progress in FOC Apr 1, 2026

kaola526 and others added 5 commits April 2, 2026 06:08

Update subgraph-client/src/hooks/usePiecePageData.tsx

700670d

Co-authored-by: Puspendra Mahariya <95584952+silent-cipher@users.noreply.github.com>

Update subgraph-client/src/hooks/usePiecePageData.tsx

53ce6c4

Co-authored-by: Puspendra Mahariya <95584952+silent-cipher@users.noreply.github.com>

Update subgraph-client/src/hooks/usePiecePageData.tsx

eed29e4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update subgraph-client/src/hooks/usePiecePageData.tsx

70ac073

Co-authored-by: Puspendra Mahariya <95584952+silent-cipher@users.noreply.github.com>

fix build

15084f7

kaola526 commented Apr 2, 2026

View reviewed changes

rjan90 requested a review from silent-cipher April 3, 2026 04:36

silent-cipher requested changes Apr 3, 2026

View reviewed changes

First checked CID.

d902184

silent-cipher requested changes Apr 8, 2026

View reviewed changes

Comment thread subgraph-client/src/pages/Landing.tsx Outdated

Comment thread subgraph-client/src/pages/Landing.tsx Outdated

kaola526 and others added 2 commits April 11, 2026 11:10

Update subgraph-client/src/pages/Landing.tsx

3debba3

Co-authored-by: Puspendra Mahariya <95584952+silent-cipher@users.noreply.github.com>

Update subgraph-client/src/pages/Landing.tsx

f0bce9b

Co-authored-by: Puspendra Mahariya <95584952+silent-cipher@users.noreply.github.com>

silent-cipher approved these changes Apr 14, 2026

View reviewed changes

github-project-automation bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FOC Apr 14, 2026

kaola526 merged commit 929dac8 into main Apr 14, 2026
3 checks passed

github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Apr 14, 2026

Conversation

kaola526 commented Apr 1, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

kaola526 Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

kaola526 commented Apr 1, 2026

Uh oh!

beck-8 commented Apr 1, 2026

Uh oh!

beck-8 commented Apr 1, 2026

Uh oh!

silent-cipher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kaola526 left a comment

Choose a reason for hiding this comment

Uh oh!

silent-cipher left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BigLep commented Apr 8, 2026

Uh oh!

kaola526 commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kaola526 commented Apr 1, 2026 •

edited by Copilot AI

Loading

silent-cipher left a comment •

edited

Loading