fix: preserve pieceId during deal creation#439
Merged
silent-cipher merged 5 commits intomainfrom Apr 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the backend deal-creation flow to better preserve pieceId when executeUpload() returns an uploadResult without it, using the onPiecesConfirmed progress event as a fallback so later piece cleanup remains possible.
Changes:
- Capture
pieceIdfrom theonPiecesConfirmedupload progress event (fallback source). - Avoid overwriting an already-set
deal.pieceIdwith a missinguploadResult.pieceId. - Update unit test typings to model
pieceIdsasbigint[]and emit abigintin the mocked progress event.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/backend/src/deal/deal.service.ts | Sets deal.pieceId during onPiecesConfirmed and preserves it when uploadResult.pieceId is nullish. |
| apps/backend/src/deal/deal.service.spec.ts | Adjusts mocked upload progress event typing/data to use bigint[] for pieceIds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SgtPooki
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These changes address
pieceIdpreservation issues.uploadResultis often missingpieceId, so we preserve it from thepiecesConfirmedevent. This is important for cleaning up pieces later on.Problem
Missing
pieceIdwhile testing locally -