Skip to content

Fix #1419: allow Map.Entry shape/format overrides #5397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cowtowncoder merged 30 commits into from
Jan 5, 2026
Merged

Fix #1419: allow Map.Entry shape/format overrides #5397

cowtowncoder merged 30 commits into from
Jan 5, 2026
+417 −74

Conversation

@cowtowncoder
Copy link
Member

@cowtowncoder cowtowncoder commented Nov 17, 2025 •
edited
Loading

Implements #1419.

@cowtowncoder
Copy link
Member Author

cowtowncoder commented Nov 17, 2025

Not loving replicating of subset of BeanDeserializer but apparently less complex than alternatives.

cowtowncoder
cowtowncoder commented Nov 19, 2025
View reviewed changes
src/main/java/tools/jackson/databind/deser/jdk/MapEntryDeserializer.java Outdated
return (Map.Entry<Object,Object>) ctxt.handleUnexpectedToken(getValueType(ctxt), p);
}

final KeyDeserializer keyDes = _keyDeserializer;
Copy link
Member Author

@cowtowncoder cowtowncoder Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually wrong: KeyDeserializer is only good for JSON Object property names; here we need a proper ValueDeserializer...

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

🧪 Code Coverage Report

Metric Coverage
Instructions coverage 78.7%
Branches branches 72.4%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

🧪 Code Coverage Report

Metric Coverage
Instructions coverage 78.7%
Branches branches 72.4%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.7% 📈 +0.0%
Branches branches 72.5% 📈 +0.0%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.7% 📈 +0.000%
Branches branches 72.4% 📉 -0.100%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.7% 📈 +0.000%
Branches branches 72.4% 📉 -0.100%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Dec 13, 2025

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.7% 📈 +0.000%
Branches branches 72.5% 📈 +0.000%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Dec 20, 2025

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.75% 📉 -0.020%
Branches branches 72.49% 📉 -0.040%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.53% 📉 -0.010%
Branches branches 72.07% 📉 -0.030%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.50% 📉 -0.040%
Branches branches 72.00% 📉 -0.090%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.49% 📉 -0.050%
Branches branches 72.01% 📉 -0.080%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.49% 📉 -0.050%
Branches branches 71.99% 📉 -0.100%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.49% 📉 -0.050%
Branches branches 72.02% 📉 -0.070%

Coverage data generated from JaCoCo test results

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.49% 📉 -0.050%
Branches branches 72.00% 📉 -0.090%

Coverage data generated from JaCoCo test results

@cowtowncoder cowtowncoder marked this pull request as ready for review January 5, 2026 18:13
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.49% 📉 -0.050%
Branches branches 72.01% 📉 -0.080%

Coverage data generated from JaCoCo test results

@cowtowncoder cowtowncoder merged commit 54215f2 into 3.x Jan 5, 2026
6 checks passed
@cowtowncoder cowtowncoder deleted the tatu-claude/3.1/1419-map-entry-shape-override branch January 5, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cowtowncoder