Fix #4983:`@JsonTypeInfo` location actual baseType via hierarchy by blacelle · Pull Request #4988 · FasterXML/jackson-databind

blacelle · 2025-02-26T11:58:20Z

cowtowncoder · 2026-03-23T00:31:27Z

@blacelle Ok, yes, although I wish traversal did not need to be done in AnnotationIntrospector, I suspect that is the way to go instead of huge refactoring trying to have more general mechanism.

So a new PR against 3.x would be good & I can help get that merged.
Thank you for your patience with this one.

blacelle · 2026-03-23T04:20:40Z

@cowtowncoder This is rebased on 3.x and adjusted following review. Thanks

github-actions · 2026-03-23T22:28:29Z

🧪 Code Coverage Report

Metric	Coverage
Instructions	81.36%
Branches	74.62%

Coverage data generated from JaCoCo test results

blacelle · 2026-03-24T07:45:32Z

BTW @cowtowncoder I have issues to run tests in some IDE (both Eclipse and Intellij) around JMPS/JDK9 modules. It's fine with 2.19 branch (probably not/less/different tests modules).

…sonTypeInfo.Id.MINIMAL_CLASS

cowtowncoder · 2026-03-24T15:58:24Z

@blacelle I also have problems running tests from Eclipse: need to use "Run Configurations" to select different JDK. I do see problem indicators for module-info.class but they do not appear to block running tests.
Maven from command-line has no problems running anything. :-/

github-actions · 2026-03-24T16:01:59Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	81.37%	📈 +0.010%
Branches	74.64%	📈 +0.000%

Coverage data generated from JaCoCo test results

cowtowncoder · 2026-03-25T00:42:43Z

@blacelle Looks pretty good, only minor things to change. But aside from those, before I can merge this we'll need a CLA (unless you have sent one before). It needs to be sent just once before merging the first contribution and is good for all future prs.

Document is here: https://github.com/FasterXML/jackson/blob/main/CLA-jackson-2026.pdf
and the usual way is to print, fill & sign, scan/photo, email to cla at fasterxml dot com.

Looking forward to merging this; big thank you for contributing the pr!

blacelle · 2026-03-25T05:31:10Z

@cowtowncoder CLA is sent. PR is progressed ; one element looks opinionated.

Thanks a lot, the contribution experience is quite smooth.

…ing a JavaType detectedBaseType

github-actions · 2026-03-25T18:21:21Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	81.37%	📈 +0.000%
Branches	74.64%	📈 +0.000%

Coverage data generated from JaCoCo test results

cowtowncoder

Almost there, just minor Javadoc additions needed.

blacelle · 2026-03-26T05:20:14Z

Done. I also restored the StdTypeResolverBuilder(JsonTypeInfo.Value settings) constructor.

github-actions · 2026-03-26T19:18:21Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	81.36%	📈 +0.010%
Branches	74.63%	📈 +0.010%

Coverage data generated from JaCoCo test results

github-actions · 2026-03-26T21:48:57Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	81.36%	📈 +0.010%
Branches	74.63%	📈 +0.010%

Coverage data generated from JaCoCo test results

cowtowncoder · 2026-03-27T16:12:48Z

@@ -297,7 +312,7 @@ protected TypeResolverBuilder<?> _findTypeResolver(MapperConfig<?> config,
    }

    protected TypeResolverBuilder<?> _constructStdTypeResolverBuilder(MapperConfig<?> config,


Whops. Change of this signature broke XML backend: will patch.

(granted, sub-classing and overriding protected method not clean extension but....

blacelle mentioned this pull request Feb 26, 2025

JsonTypeInfo.Id.MINIMAL_CLASS generates invalid type on sub-package #4983

Closed

cowtowncoder reviewed Mar 22, 2026

View reviewed changes

Comment thread src/main/java/com/fasterxml/jackson/databind/introspect/JacksonAnnotationIntrospector.java Outdated

cowtowncoder changed the title ~~JsonInfoType Using annotationHolder as actual baseType for id as clas…~~ JsonInfoType Using annotationHolder as actual baseType for id as className Mar 22, 2026

cowtowncoder reviewed Mar 22, 2026

View reviewed changes

Comment thread src/main/java/com/fasterxml/jackson/databind/introspect/JacksonAnnotationIntrospector.java Outdated

cowtowncoder reviewed Mar 22, 2026

View reviewed changes

Comment thread src/main/java/com/fasterxml/jackson/databind/introspect/JacksonAnnotationIntrospector.java Outdated

blacelle force-pushed the jsoninfotype/useAnnotationHolderAsBase branch from a9b6def to dcbc97c Compare March 23, 2026 04:17

blacelle changed the base branch from 2.19 to 3.x March 23, 2026 04:17

blacelle marked this pull request as ready for review March 23, 2026 04:18

cowtowncoder changed the title ~~JsonInfoType Using annotationHolder as actual baseType for id as className~~ @JsonTypeInfo location actual baseType via hierarchy Mar 24, 2026

cowtowncoder reviewed Mar 24, 2026

View reviewed changes

Comment thread src/main/java/tools/jackson/databind/jsontype/impl/StdTypeResolverBuilder.java Outdated

cowtowncoder reviewed Mar 24, 2026

View reviewed changes

Comment thread src/main/java/tools/jackson/databind/jsontype/TypeResolverProvider.java Outdated

cowtowncoder reviewed Mar 24, 2026

View reviewed changes

Comment thread src/main/java/tools/jackson/databind/jsontype/TypeResolverProvider.java Outdated

blacelle added 2 commits March 24, 2026 11:51

Rely on AnnotatedClass.superTypes() to infer the actual package for J…

e251cac

…sonTypeInfo.Id.MINIMAL_CLASS

Rebase and follow review

62032a2

blacelle force-pushed the jsoninfotype/useAnnotationHolderAsBase branch from 6d07ab5 to 62032a2 Compare March 24, 2026 07:51

blacelle requested a review from cowtowncoder March 24, 2026 07:52

cowtowncoder reviewed Mar 25, 2026

View reviewed changes

Comment thread src/main/java/tools/jackson/databind/jsontype/impl/StdTypeResolverBuilder.java

cowtowncoder reviewed Mar 25, 2026

View reviewed changes

Comment thread src/test/java/tools/jackson/databind/jsontype/TestSubtypesSubPackage.java

cowtowncoder reviewed Mar 25, 2026

View reviewed changes

Comment thread src/main/java/tools/jackson/databind/jsontype/impl/StdTypeResolverBuilder.java Outdated

cowtowncoder reviewed Mar 25, 2026

View reviewed changes

Comment thread src/main/java/tools/jackson/databind/jsontype/impl/StdTypeResolverBuilder.java

cowtowncoder changed the title ~~@JsonTypeInfo location actual baseType via hierarchy~~ Fix #4983:@JsonTypeInfo location actual baseType via hierarchy Mar 25, 2026

Add comments, add final marker to detectedBaseType

0d68a99

cowtowncoder added the cla-received PR already covered by CLA (optional label) label Mar 25, 2026

Restore constructor with deprecation notice, and a constructor accept…

8858f0e

…ing a JavaType detectedBaseType

cowtowncoder reviewed Mar 26, 2026

View reviewed changes

Comment thread src/main/java/tools/jackson/databind/jsontype/impl/StdTypeResolverBuilder.java

cowtowncoder reviewed Mar 26, 2026

View reviewed changes

Comment thread src/main/java/tools/jackson/databind/jsontype/impl/StdTypeResolverBuilder.java

cowtowncoder reviewed Mar 26, 2026

View reviewed changes

Restore legacy ctor, add '@SInCE 3.2' javadoc

789a06d

cowtowncoder reviewed Mar 26, 2026

View reviewed changes

Comment thread src/main/java/tools/jackson/databind/jsontype/impl/StdTypeResolverBuilder.java Outdated

Fix deprecation notices

1cdfbab

blacelle requested a review from cowtowncoder March 26, 2026 19:22

cowtowncoder approved these changes Mar 26, 2026

View reviewed changes

cowtowncoder added the 3.2 label Mar 26, 2026

cowtowncoder added this to the 3.2.0 milestone Mar 26, 2026

cowtowncoder merged commit 590acf6 into FasterXML:3.x Mar 26, 2026
6 checks passed

blacelle mentioned this pull request Mar 27, 2026

Faulty Serialization using Id.MINIMAL_CLASS #5247

Closed

1 task

cowtowncoder reviewed Mar 27, 2026

View reviewed changes

cowtowncoder added a commit that referenced this pull request Mar 27, 2026

Fix a minor regression from #4988

81a85ca

cowtowncoder added a commit that referenced this pull request Mar 27, 2026

Fix a minor regression from #4988 (#5844)

e7a0198

blacelle deleted the jsoninfotype/useAnnotationHolderAsBase branch May 3, 2026 06:08

		@@ -297,7 +312,7 @@ protected TypeResolverBuilder<?> _findTypeResolver(MapperConfig<?> config,
		}

		protected TypeResolverBuilder<?> _constructStdTypeResolverBuilder(MapperConfig<?> config,

Uh oh!

Conversation

blacelle commented Feb 26, 2025 • edited by cowtowncoder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cowtowncoder commented Mar 23, 2026

Uh oh!

blacelle commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

🧪 Code Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blacelle commented Mar 24, 2026

Uh oh!

cowtowncoder commented Mar 24, 2026

Uh oh!

github-actions Bot commented Mar 24, 2026

🧪 Code Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cowtowncoder commented Mar 25, 2026

Uh oh!

blacelle commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

🧪 Code Coverage Report

Uh oh!

Uh oh!

Uh oh!

cowtowncoder left a comment

Choose a reason for hiding this comment

Uh oh!

blacelle commented Mar 26, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

🧪 Code Coverage Report

Uh oh!

Uh oh!

github-actions Bot commented Mar 26, 2026

🧪 Code Coverage Report

Uh oh!

Uh oh!

cowtowncoder Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

blacelle commented Feb 26, 2025 •

edited by cowtowncoder

Loading

cowtowncoder Mar 27, 2026 •

edited

Loading