Flat versions, quick fix for Gradle consumers #81#82
Flat versions, quick fix for Gradle consumers #81#82elect86 wants to merge 4 commits intoFasterXML:2.17from
Conversation
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-annotations</artifactId> | ||
| <version>${jackson.version.annotations}</version> |
There was a problem hiding this comment.
Based on Kotlin example, it sounds like 1 intermediate level is acceptable, but no more -- if so, wouldn't this actually still work? (since it's jackson.version.annotations -> jackson.version).
Or conversely, if it has to be direct reference, wouldn't we need to use ${jackson.version} directly for Kotlin and Scala modules?
There was a problem hiding this comment.
I'm having issue to define exactly the conditions that trigger this problem
In my current situation, I have a multi-module build, with one of the module being platform1 (bom), which depends on another (external) platform2, which depends on jackson-bom:2.16.1
In this scenario, in the common module depending on platform, I declare a dependency on api("com.fasterxml.jackson.module:jackson-module-kotlin"), but I get:
unresolved dependency for "com.fasterxml.jackson.module:jackson-module-kotlin:."
-common
-platform1
-platform2
-`jackson-bom:2.16.1`
Therefore I immediately connected this at the problem I had time ago with jna in Scijava
<jna.version>5.14.0</jna.version>
<jna-platform.version>${jna.version}</jna-platform.version>
<net.java.dev.jna.jna.version>${jna.version}</net.java.dev.jna.jna.version>
<net.java.dev.jna.jna-platform.version>${jna-platform.version}</net.java.dev.jna.jna-platform.version>
That's why Vampire was helping me defining a virtual platform to force a manual alignment between jna and jna-platform here, which unfortunately turned out to be buggy
However I just created a new project from scratch and this seems fine (same module, though)
api(platform("com.fasterxml.jackson:jackson-bom:2.16.1"))
api("com.fasterxml.jackson.module:jackson-module-kotlin")
So, I think this is driving me crazy
There was a problem hiding this comment.
There hasn't much change in this area, but latest Jackson is 2.18.2 just in case something in poms might be relevant.
Also: if issue is reproducible just with Kotlin module (and perhaps for Scala), then it'd be good to shorten just those 2 paths I think (and leave the rest as they are)
There was a problem hiding this comment.
@elect86 If you only overrode Kotlin and Scala module version refs, would it still cover your use case? Or are other simplifications still needed?
I appreciate reproducing issue may be difficult but it'd be great to have minimal patch, if at all practical.
No description provided.