Main to next chunk 2#1127
Merged
Merged
Conversation
TreeList is an immutable collection ported from Scala's Vector class
Co-authored-by: Alwinfy <20421383+Alwinfy@users.noreply.github.com>
s5bug
force-pushed
the
main-to-next-chunk2
branch
from
1c47eaa to
62f5e6f
Compare
s5bug
force-pushed
the
main-to-next-chunk2
branch
from
62f5e6f to
e51de9e
Compare
s5bug
force-pushed
the
main-to-next-chunk2
branch
from
e51de9e to
e69afcb
Compare
object-Object
approved these changes
Jun 10, 2026
object-Object
left a comment
object-Object
left a comment
Member
There was a problem hiding this comment.
LGTM with some deprecation removals
Comment on lines
+32
to
+33
| val acc: MutableList<Iota> | ||
| val immutableAcc: TreeList<Iota> |
Member
There was a problem hiding this comment.
Let's rename this back to acc now
Comment on lines
+36
to
+45
| @Deprecated("use the primary constructor that accepts a TreeList instead") | ||
| constructor( | ||
| data: SpellList, | ||
| code: SpellList, | ||
| baseStack: List<Iota>?, | ||
| acc: MutableList<Iota> | ||
| ) : this(data, code, baseStack, TreeList.from(acc)) | ||
|
|
||
| @Deprecated("access immutableAcc instead") | ||
| val acc: MutableList<Iota> get() = immutableAcc.toMutableList() |
Comment on lines
91
to
128
Member
There was a problem hiding this comment.
Let's remove the deprecated overload now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1126
Includes PRs: