Add config toggle for the iota NBT dump with advanced tooltips#1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if Advanced Tooltips is enabled, iota-holding items will display the full NBT of their stored iota in their tooltip, which can get very unwieldy. This PR adds a client config toggle to enable/disable this feature. Since it's largely a debug tool, the config toggle is disabled by default.
The
HexConfig.client() == nullbefore the check for the actual config value is there in caseappendHoverText()ever gets called on the server side on Fabric (which doesn't have a client config on the server). I have no idea if this is actually possible in vanilla+hex, but I figured better safe than sorry.