refactor: remove single-pass review mode#62
Open
varin-nair-factory wants to merge 1 commit intodevfrom
Open
Conversation
The candidate-validator two-pass review is strictly better than single-pass. Remove the review_use_validator flag, the single-pass prompt template, and all associated conditional logic. The validator step now always runs for code reviews. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The candidate-validator two-pass review is strictly better than single-pass. This PR removes the
review_use_validatorflag, the single-pass prompt template, and all associated conditional logic. The validator step now always runs for code reviews.Changes
review_use_validator,review_candidates_path, andreview_validated_pathinputs from bothaction.ymlandreview/action.ymlsrc/tag/commands/review.tsandsrc/entrypoints/generate-review-prompt.tsto always use the candidate-validator two-pass flowsrc/entrypoints/prepare-validator.tsDROID_SUCCESSexpressionsreview-prompt.ts), its test, and the prepare-validator testTask,FetchUrl, no PR mutation tools)Impact
No functional change for users since
review_use_validatoralready defaulted totrue. Net deletion of ~850 lines.Linear: FAC-16957