Skip to content

Conversation

@Logiquo
Copy link
Contributor

@Logiquo Logiquo commented Aug 17, 2021

WIP. Feedback is welcomed.

@Logiquo Logiquo marked this pull request as draft August 17, 2021 09:06
@liach
Copy link
Contributor

liach commented Aug 17, 2021

Imo we should just do a major version bump to like 0.6 so as to avoid having a lot of Deprecated stuff that's hard to clean up.

If users do have to use two libraries depending on conflicting versions of tiny remapper, why don't they use the remapper to remap the old library :trollface: this is what the remapper exists for.

@Logiquo
Copy link
Contributor Author

Logiquo commented Aug 17, 2021

Of course, that would be much easier to this kind of refactoring, but consider we just bumped the version to 0.5 not so long ago, I don't know if this is feasible. @sfPlayer1 what's your idea?

@liach
Copy link
Contributor

liach commented Aug 18, 2021

override autocloseable close to throw no checked exceptions so users can use try with resources without a catch block

@Logiquo
Copy link
Contributor Author

Logiquo commented Aug 18, 2021

resolve #71 .

@Logiquo Logiquo marked this pull request as ready for review August 21, 2021 00:22
@Logiquo
Copy link
Contributor Author

Logiquo commented Aug 21, 2021

Should have emulated all old API calls. Please let me know if I forget anything.

@Logiquo Logiquo marked this pull request as draft September 9, 2021 05:37
@Logiquo Logiquo marked this pull request as ready for review September 23, 2021 21:00
@Logiquo Logiquo changed the title Separate API and implementation for tiny-remapper. [Refactor] Add InputSupplier API for supporting different way of inputs. Sep 23, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants